Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress empty description test #1521

Open
wants to merge 3 commits into
base: helm-framework
Choose a base branch
from

Conversation

JaylonmcShan03
Copy link
Contributor

@JaylonmcShan03 JaylonmcShan03 commented Oct 28, 2024

Description

This pr adds a test for the suppress empty description logic we have in place for the Description attribute

When running the test, I am getting an weird error where after applying the first step, terraform still detects a change, which with my understanding means the suppression logic isn't taking affect as intended. I am not sure what the hiccup is, because after review the logic it looks perfectly fine to me! Can I get a second pair of eyes on this, there could be something I am not thinking of!

Logs from the test >

`st_name=TestAccResourceRelease_suppressEmptyDescription test_terraform_path=/opt/homebrew/bin/terraform
  error=
  | After applying this test step, the non-refresh plan was not empty.
  | stdout:
  | 
  | 
  | Terraform used the selected providers to generate the following execution
  | plan. Resource actions are indicated with the following symbols:
  |   ~ update in-place
  | 
  | Terraform will perform the following actions:
  | 
  |   # helm_release.test will be updated in-place
  |   ~ resource "helm_release" "test" {
  |       ~ id                         = "suppress-empty-zbqhn4f818" -> (known after apply)
  |       ~ metadata                   = {
  |           ~ app_version    = "1.19.5" -> (known after apply)
  |           ~ chart          = "test-chart" -> (known after apply)
  |           ~ first_deployed = 1730138553 -> (known after apply)
  |           ~ last_deployed  = 1730138566 -> (known after apply)
  |           ~ name           = "suppress-empty-zbqhn4f818" -> (known after apply)
  |           ~ namespace      = "terraform-acc-test-v08zv4w1zi" -> (known after apply)
  |           ~ revision       = 2 -> (known after apply)
  |           ~ values         = jsonencode({}) -> (known after apply)
  |           ~ version        = "1.2.3" -> (known after apply)
  |         } -> (known after apply)
  |         name                       = "suppress-empty-zbqhn4f818"
  |         # (27 unchanged attributes hidden)
  |     }
  | 
  | Plan: 0 to add, 1 to change, 0 to destroy.
  
    resource_helm_release_test.go:714: Step 2/2 error: After applying this test step, the non-refresh plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # helm_release.test will be updated in-place
          ~ resource "helm_release" "test" {
              ~ id                         = "suppress-empty-zbqhn4f818" -> (known after apply)
              ~ metadata                   = {
                  ~ app_version    = "1.19.5" -> (known after apply)
                  ~ chart          = "test-chart" -> (known after apply)
                  ~ first_deployed = 1730138553 -> (known after apply)
                  ~ last_deployed  = 1730138566 -> (known after apply)
                  ~ name           = "suppress-empty-zbqhn4f818" -> (known after apply)
                  ~ namespace      = "terraform-acc-test-v08zv4w1zi" -> (known after apply)
                  ~ revision       = 2 -> (known after apply)
                  ~ values         = jsonencode({}) -> (known after apply)
                  ~ version        = "1.2.3" -> (known after apply)
                } -> (known after apply)
                name                       = "suppress-empty-zbqhn4f818"
                # (27 unchanged attributes hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.`

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@JaylonmcShan03 JaylonmcShan03 requested a review from a team as a code owner October 28, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant