-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect drifts between the manifest and its live Kubernetes resources #1442
base: main
Are you sure you want to change the base?
Conversation
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
# Conflicts: # go.mod
# Conflicts: # go.mod # go.sum
# Conflicts: # helm/resource_release.go
@BBBmau is there a way we could get your review on that one 🙏 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @chotiwat, thanks for the changes. Could you please add a change log?
@sheneska done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @chotiwat , thank you for your proposed changes! We are currently working on migrating from the SDK to framework plugin, once this is completed we can proceed with reviewing this PR.
Description
This PR aims to address #1095 by performing a dry-run, server-side apply of the manifest during planning, which allows Terraform to detect any changes to the Kubernetes resources managed by the Helm release.
Mini Changelog
resources
attribute which tracks Kubernetes resources managed by the deployed Helm releasekube-controller-manager
or updated via subresource APIs (e.g./status
and/scale
) are removed to avoid perpetual drifts.manifest
attribute.uid
,creationTimestamp
,resourceVersion
, andmanagedFields
are scrubbed to prevent the inconsistent final plan issue.resources
during planning using a dry-run, server-side apply for diffingAcceptance tests
Release Note
Release note for CHANGELOG:
References
#1095
#1239
Community Note