-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(TFECO-7637) Raise HCL diagnostics #1850
Conversation
620360e
to
17bfb0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a few things when I tried to use this feature. These don't require changes to this PR, but rather to terraform-schema. I am sorry that I missed them during the review of hashicorp/terraform-schema#412 and am only bringing them up now.
Maybe we can add more test cases to the decoder in terraform-schema to cover them.
We need to check that req.Source
and req.VersionConstraints
are both not null when iterating over the requirements, to avoid crashing due to a null pointer dereference.
Both diagnostic messages contain nil
because we are using an empty field in our string (e.g. pr.source
instead of source.AsString()
).
9b83982
to
3d38cf7
Compare
This change updates the stack metadata loading to merge the new diagnostics with the existing ones. This is necessary to ensure that we don't lose any diagnostics that were previously reported.
3d38cf7
to
a913ef0
Compare
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This change updates the stack metadata loading to merge the new diagnostics with the existing ones. This is necessary to ensure that we don't lose any diagnostics that were previously reported.
Needs hashicorp/terraform-schema#412