Resolve version correctly for backend schema #1453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address:
terraform_remote_state
config
incorrectly flagged with errors vscode-terraform#1580Depends on:
CoreModuleSchemaForConstraint
w/ResolveVersion
terraform-schema#275This PR changes the meaning of the version in the snippet of code being changed. Previously it referred to the discovered/installed Terraform version, whether or not we had the schema for it. With this patch, the meaning changes to "language/schema version".
In practice though it remains the same for the likely majority of cases (any stable version between
0.12
and1.6
) but not for the other cases, where we fall back on either 0.12.0 or latest known version (currently 1.6.0).Importantly, this does not impact the discovered/installed version we persist and make available, e.g. here
Also, the new logic inside
ResolveVersion
reflects the way we handled various edge cases in the previous implementation, as shown in the attached test in hashicorp/terraform-schema#275