Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ParseVariables for single files #1422

Merged
merged 10 commits into from
Oct 3, 2023
Merged

Update ParseVariables for single files #1422

merged 10 commits into from
Oct 3, 2023

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Sep 26, 2023

Modifies ParsedVarsFiles to only re-parse the single tfvars file which is being changed, if the job was scheduled as part of textDocument/didChange request.

This is a follow up to #1404 which updated the parsing job for terraform files.

@jpogran jpogran self-assigned this Sep 26, 2023
@jpogran jpogran force-pushed the update_parsevariables_for_single_files branch from 334433f to f97a0d3 Compare September 27, 2023 13:19
@jpogran jpogran linked an issue Sep 27, 2023 that may be closed by this pull request
Update ParseVarsConfiguration to only parse changed file (*.tfvars) #1418
Closed
@jpogran jpogran force-pushed the update_parsevariables_for_single_files branch 3 times, most recently from 4828c43 to b2e2829 Compare September 28, 2023 17:47
@jpogran jpogran marked this pull request as ready for review September 28, 2023 19:33
@jpogran jpogran requested a review from a team as a code owner September 28, 2023 19:33
@radeksimko radeksimko added enhancement New feature or request performance Gotta go fast labels Sep 29, 2023
radeksimko
radeksimko reviewed Sep 29, 2023
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with mostly naming nitpicks and one suggestion about the test.

internal/terraform/ast/variables.go Outdated Show resolved Hide resolved
internal/terraform/ast/variables.go Outdated Show resolved Hide resolved
internal/terraform/module/module_ops.go Outdated Show resolved Hide resolved
internal/terraform/module/module_ops.go Outdated Show resolved Hide resolved
internal/terraform/module/module_ops_test.go Outdated Show resolved Hide resolved
internal/terraform/module/module_ops_test.go Outdated Show resolved Hide resolved
internal/terraform/module/module_ops_test.go Outdated Show resolved Hide resolved
internal/terraform/module/module_ops_test.go Outdated Show resolved Hide resolved
internal/terraform/module/module_ops_test.go Show resolved Hide resolved
internal/terraform/module/module_ops_test.go Outdated Show resolved Hide resolved
jpogran and others added 3 commits September 29, 2023 14:14
@jpogran
Update ParseVariables for single files
9e1e96b 
Modifies ParsedVarsFiles to only re-parse the single tfvars file which is being changed, if the job was scheduled as part of `textDocument/didChange` request.

This is a follow up to #1404 which updated the parsing job for terraform files.
@jpogran
use uri
abc5741
@jpogran @radeksimko
Apply suggestions from code review
f6fb85e 
Co-authored-by: Radek Simko <[email protected]>
@jpogran jpogran force-pushed the update_parsevariables_for_single_files branch from efd5404 to f6fb85e Compare September 29, 2023 18:17
radeksimko
radeksimko approved these changes Oct 3, 2023
View reviewed changes
internal/terraform/module/module_ops_test.go Outdated Show resolved Hide resolved
internal/terraform/module/module_ops_test.go Outdated Show resolved Hide resolved
internal/terraform/module/module_ops_test.go Outdated Show resolved Hide resolved
@radeksimko radeksimko mentioned this pull request Oct 3, 2023
Merged
@jpogran jpogran merged commit 449d442 into main Oct 3, 2023
20 checks passed
@jpogran jpogran deleted the update_parsevariables_for_single_files branch October 3, 2023 13:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
@xiehan xiehan added this to the v0.32.0 (tentative) milestone Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees

@jpogran jpogran

Labels
enhancement New feature or request performance Gotta go fast
Projects
None yet
Milestone
v0.32.0
Development

Successfully merging this pull request may close these issues.

Update ParseVarsConfiguration to only parse changed file (*.tfvars)
3 participants
@jpogran @radeksimko @xiehan