Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update transaction description field #1404

Closed
wants to merge 2 commits into from

Conversation

SimiHunjan
Copy link
Contributor

Description:

Update the description field when creating a transaction and viewing the transaction details.
Related issue(s):

Fixes #1403

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@SimiHunjan SimiHunjan force-pushed the feat/update-transaction-description-field branch from 7614409 to 91358ef Compare December 20, 2024 05:37
@SimiHunjan SimiHunjan self-assigned this Dec 20, 2024
@SimiHunjan SimiHunjan marked this pull request as ready for review December 20, 2024 06:06
@@ -528,6 +528,7 @@ const sectionHeadingClass = 'd-flex justify-content-between align-items-center';
const detailItemLabelClass = 'text-micro text-semi-bold text-dark-blue';
const detailItemValueClass = 'text-small mt-1';
const commonColClass = 'col-6 col-lg-5 col-xl-4 col-xxl-3 overflow-hidden py-3';
const descriptionColClass = 'col-12 col-lg-12 col-xl-12 col-xxl-12\'';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need for multiple col-12's
Bootstrap uses the min-width media queries so that you can leave only col-12 and it will apply to any larger screens

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then since it is only a single class, you don't need a variable for that

@@ -629,7 +630,9 @@ const cancel = 'Cancel';
"
>
<h4 :class="detailItemLabelClass">Description</h4>
<p :class="detailItemValueClass" data-testid="p-description-field">
<p :class="detailItemValueClass" data-testid="p-description-field"
style="white-space: normal; word-break: break-word; overflow-wrap: break-word;"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline styles are bad practice, consider adding the text-break to the detailItemValueClass and remove the inline styles

@SvetBorislavov SvetBorislavov changed the title Feat/update transaction description field feat: update transaction description field Dec 20, 2024
@jsync-swirlds jsync-swirlds requested review from jbair06 and removed request for jsync-swirlds December 20, 2024 18:19
@SimiHunjan
Copy link
Contributor Author

new PR due to signing issues: #1409

@SimiHunjan SimiHunjan closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the "Description" field for creating a transaction and viewing the transaction details
2 participants