-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update transaction description field #1404
Conversation
Signed-off-by: Simi Hunjan <[email protected]>
7614409
to
91358ef
Compare
Signed-off-by: Simi Hunjan <[email protected]>
@@ -528,6 +528,7 @@ const sectionHeadingClass = 'd-flex justify-content-between align-items-center'; | |||
const detailItemLabelClass = 'text-micro text-semi-bold text-dark-blue'; | |||
const detailItemValueClass = 'text-small mt-1'; | |||
const commonColClass = 'col-6 col-lg-5 col-xl-4 col-xxl-3 overflow-hidden py-3'; | |||
const descriptionColClass = 'col-12 col-lg-12 col-xl-12 col-xxl-12\''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need for multiple col-12's
Bootstrap uses the min-width media queries so that you can leave only col-12
and it will apply to any larger screens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then since it is only a single class, you don't need a variable for that
@@ -629,7 +630,9 @@ const cancel = 'Cancel'; | |||
" | |||
> | |||
<h4 :class="detailItemLabelClass">Description</h4> | |||
<p :class="detailItemValueClass" data-testid="p-description-field"> | |||
<p :class="detailItemValueClass" data-testid="p-description-field" | |||
style="white-space: normal; word-break: break-word; overflow-wrap: break-word;" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inline styles are bad practice, consider adding the text-break
to the detailItemValueClass
and remove the inline styles
new PR due to signing issues: #1409 |
Description:
Update the description field when creating a transaction and viewing the transaction details.
Related issue(s):
Fixes #1403
Notes for reviewer:
Checklist