Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhance consistency testing tool #17136

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

mustafauzunn
Copy link
Collaborator

Description:

Enhance the consistency testing tool to work with new transactions of bytes.

Related issue(s):

Fixes #16790

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mustafauzunn mustafauzunn added the Platform Tickets pertaining to the platform label Dec 19, 2024
@mustafauzunn mustafauzunn added this to the v0.58 milestone Dec 19, 2024
@mustafauzunn mustafauzunn self-assigned this Dec 19, 2024
Copy link

codacy-production bot commented Dec 19, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (89e2f35) 95732 65134 68.04%
Head commit (312f184) 95745 (+13) 65129 (-5) 68.02% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17136) 14 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 64.27%. Comparing base (89e2f35) to head (312f184).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
.../demo/consistency/ConsistencyTestingToolState.java 0.00% 12 Missing ⚠️
...s/demo/consistency/ConsistencyTestingToolMain.java 0.00% 1 Missing ⚠️
...n/java/com/swirlds/platform/system/SwirldMain.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #17136      +/-   ##
=============================================
- Coverage      64.28%   64.27%   -0.02%     
+ Complexity     20883    20881       -2     
=============================================
  Files           2549     2549              
  Lines          95969    95982      +13     
  Branches       10041    10043       +2     
=============================================
- Hits           61691    61688       -3     
- Misses         30644    30662      +18     
+ Partials        3634     3632       -2     
Files with missing lines Coverage Δ
...s/demo/consistency/ConsistencyTestingToolMain.java 0.00% <0.00%> (ø)
...n/java/com/swirlds/platform/system/SwirldMain.java 0.00% <0.00%> (ø)
.../demo/consistency/ConsistencyTestingToolState.java 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

Impacted file tree graph

…com:hashgraph/hedera-services into 16790-enhance-consistency-testing-tool

# Conflicts:
#	platform-sdk/platform-apps/tests/ConsistencyTestingTool/src/main/java/com/swirlds/demo/consistency/ConsistencyTestingToolState.java
…com:hashgraph/hedera-services into 16790-enhance-consistency-testing-tool
@mustafauzunn mustafauzunn changed the base branch from develop to 16703-refactor-consumer-system-transactions December 20, 2024 11:39
Signed-off-by: Mustafa Uzun <[email protected]>
Base automatically changed from 16703-refactor-consumer-system-transactions to develop December 20, 2024 12:58
…6790-enhance-consistency-testing-tool

# Conflicts:
#	platform-sdk/platform-apps/demos/CryptocurrencyDemo/src/main/java/com/swirlds/demo/crypto/CryptocurrencyDemoState.java
#	platform-sdk/platform-apps/demos/HelloSwirldDemo/src/main/java/com/swirlds/demo/hello/HelloSwirldDemoState.java
#	platform-sdk/platform-apps/demos/StatsDemo/src/main/java/com/swirlds/demo/stats/StatsDemoState.java
#	platform-sdk/platform-apps/tests/AddressBookTestingTool/src/main/java/com/swirlds/demo/addressbook/AddressBookTestingToolState.java
#	platform-sdk/platform-apps/tests/ConsistencyTestingTool/src/main/java/com/swirlds/demo/consistency/ConsistencyTestingToolState.java
#	platform-sdk/platform-apps/tests/ISSTestingTool/src/main/java/com/swirlds/demo/iss/ISSTestingToolState.java
#	platform-sdk/platform-apps/tests/MigrationTestingTool/src/main/java/com/swirlds/demo/migration/MigrationTestingToolState.java
#	platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/platform/PlatformTestingToolState.java
#	platform-sdk/platform-apps/tests/StatsSigningTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolState.java
#	platform-sdk/platform-apps/tests/StressTestingTool/src/main/java/com/swirlds/demo/stress/StressTestingToolState.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/PlatformMerkleStateRoot.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/SwirldState.java
#	platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/turtle/runner/TurtleTestingToolState.java
#	platform-sdk/swirlds-platform-core/src/testFixtures/java/com/swirlds/platform/test/fixtures/state/BlockingSwirldState.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Tickets pertaining to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt ConsistencyTestingTool to work with new proto types and enhance README
1 participant