Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Suppress child records #17072

Open
wants to merge 3 commits into
base: hip-991-submit-message
Choose a base branch
from

Conversation

JivkoKelchev
Copy link
Contributor

@JivkoKelchev JivkoKelchev commented Dec 16, 2024

Description:

Add SUPPRESSING_TRANSACTION_CUSTOMIZER when dispatching custom fee transfers.
Add assessed_custom_fees to SubmitMessageOutput for transaction output block item.
Updates stream builders and BlockItesmsTranslator to support assessedCustomFees in SubmitMessage.

Related issue(s):

Fixes #16854

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Zhivko Kelchev <[email protected]>
@JivkoKelchev JivkoKelchev self-assigned this Dec 16, 2024
@JivkoKelchev JivkoKelchev added this to the v0.58 milestone Dec 16, 2024
…message-suppress-child-records

# Conflicts:
#	hedera-node/hedera-consensus-service-impl/src/main/java/com/hedera/node/app/service/consensus/impl/handlers/ConsensusSubmitMessageHandler.java
Signed-off-by: Zhivko Kelchev <[email protected]>
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 77.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 63.89%. Comparing base (ac943c5) to head (af9a660).

Files with missing lines Patch % Lines
...m/hedera/node/app/blocks/BlockItemsTranslator.java 0.00% 4 Missing ⚠️
...edera/node/app/blocks/impl/BlockStreamBuilder.java 0.00% 2 Missing and 1 partial ⚠️
...s/impl/handlers/ConsensusSubmitMessageHandler.java 93.93% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##             hip-991-submit-message   #17072   +/-   ##
=========================================================
  Coverage                     63.89%   63.89%           
- Complexity                    20640    20649    +9     
=========================================================
  Files                          2543     2543           
  Lines                         95456    95491   +35     
  Branches                       9996    10006   +10     
=========================================================
+ Hits                          60987    61015   +28     
- Misses                        30840    30847    +7     
  Partials                       3629     3629           
Files with missing lines Coverage Δ
...s/impl/handlers/ConsensusSubmitMessageHandler.java 88.65% <93.93%> (+0.70%) ⬆️
...edera/node/app/blocks/impl/BlockStreamBuilder.java 75.53% <0.00%> (-0.62%) ⬇️
...m/hedera/node/app/blocks/BlockItemsTranslator.java 92.00% <0.00%> (-4.88%) ⬇️

... and 14 files with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 82.50%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ac943c5) 98221 64425 65.59%
Head commit (af9a660) 98256 (+35) 64453 (+28) 65.60% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17072) 40 33 82.50%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@JivkoKelchev JivkoKelchev marked this pull request as ready for review December 16, 2024 15:41
@JivkoKelchev JivkoKelchev requested review from a team as code owners December 16, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic Fees HIP-991 implementation
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

2 participants