Introduce gasUnit property to allow greater gas per second throttle
#9994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bilyana Gospodinova <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9994 +/- ##
============================================
- Coverage 92.23% 92.23% -0.01%
Complexity 7856 7856
============================================
Files 956 956
Lines 32896 32900 +4
Branches 4148 4148
============================================
+ Hits 30342 30345 +3
Misses 1579 1579
- Partials 975 976 +1 ☔ View full report in Codecov by Sentry. |
kselveliev
reviewed
Dec 20, 2024
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/throttle/ThrottleProperties.java
Show resolved
Hide resolved
kselveliev
previously approved these changes
Dec 20, 2024
Signed-off-by: Bilyana Gospodinova <[email protected]>
|
steven-sheehy
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The current bucket4j implementation does not allow a greater consumption than 1 token per nanosecond. Because of this the current max gas per second is capped at 1_000_000_000 gas.
This PR adds a new property called
hedera.mirror.web3.throttle.gasUnit. This is a multiplier that allows a mapping between the token and the gas that will be consumed in the bucket. For example, if the value of the property is set to 10, this means that 1 token in the bucket will correspond to 10 gas. This will make the max supported gas limit per second to be equal to 10_000_000_000. Please note that there might be some small precision loss due to number rounding.The implementation change is that when a request is made, the passed gas limit is divided by the configured
gasUnitproperty value (by default it is set to 1). After the transaction processing is finished, the remaining (unused) gas is then returned back to the bucket and is available to be used by another transaction.Example: a request is made with gasLimit set to 1_000_000. The
gasUnitis set to 10. This means that 100_000 tokens will be reserved in the gas throttle bucket. The transaction finishes and the actual gas used is 800_000. This means that there are 200_000 gas remaining. Using thegasUnitmultiplier, 200_000 /gasUnit= 20_000 gas will be returned back to the bucket and can be used by another transaction.Fixes #9977