Fix BytecodeUtilsTest against modularized #9993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristiyan Selveliev <[email protected]>
kselveliev
requested review from
steven-sheehy,
bilyana-gospodinova,
sdimitrov9,
nickeynikolovv and
IvanKavaldzhiev
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9993 +/- ##
=========================================
Coverage 92.23% 92.23%
Complexity 7856 7856
=========================================
Files 956 956
Lines 32896 32896
Branches 4148 4148
=========================================
+ Hits 30341 30342 +1
Misses 1579 1579
+ Partials 976 975 -1 ☔ View full report in Codecov by Sentry. |
|
steven-sheehy
approved these changes
Dec 20, 2024
steven-sheehy
deleted the
09992-fix-BytecodeUtilsTest-for-modularized
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes
BytecodeUtilsTestwhich were failing when ran against modularized flag.Made
BytecodeUtilsTestextendAbstractContractCallServiceTestand now gets initial setup which makes most of the test except for one pass.The one test that did not pass was ->
testExtractRuntimeBytecodeEthCall. The reason was that the EthCall.binary was bigger than services max transaction size with a little bit.This issue will be fixed in hashgraph/hedera-services#17099
Workaround solution for the test is:
Deleted EthCall methods -
getTokenNameandgetTokenSymbol.We have the exacts same tests in
ContractCallServiceERCTokenReadOnlyFunctionsTestso these 2 can be deleted.Deleting those decreased the binary and now it passes services max txn size check.
Changes in this PR also fix a couple of tests using the EthCall contract in
ContracCallServiceTest.This PR modifies ... in order to support ...
BytecodeUtilsTest- extendsAbstractContractCallServiceTestEthCall.sol - deletegetTokenNameandgetTokenSymbolto decrease contract binaryRelated issue(s):
Fixes #9992
Notes for reviewer:
Checklist