Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update per Q3 audit findings #776

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

mishomihov00
Copy link
Contributor

Description

This pull request changes the following:

Update per Q3 audit findings

Related Issues

@mishomihov00 mishomihov00 self-assigned this Oct 31, 2024
@mishomihov00 mishomihov00 requested review from a team as code owners October 31, 2024 09:18
@mishomihov00 mishomihov00 linked an issue Oct 31, 2024 that may be closed by this pull request
53 tasks
Copy link

Wallet Snap Unit Test Results

193 tests  ±0   193 ✅ ±0   1m 33s ⏱️ -4s
  7 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit f592e11. ± Comparison against base commit d213ea6.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d213ea6) 960 457 47.60%
Head commit (f592e11) 960 (+0) 457 (+0) 47.60% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#776) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.23%. Comparing base (d213ea6) to head (f592e11).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #776   +/-   ##
=======================================
  Coverage   49.23%   49.23%           
=======================================
  Files          12       12           
  Lines        1312     1312           
  Branches      454      454           
=======================================
  Hits          646      646           
  Misses        618      618           
  Partials       48       48           

Impacted file tree graph

@mishomihov00 mishomihov00 merged commit 488644f into main Nov 6, 2024
14 checks passed
@mishomihov00 mishomihov00 deleted the 522-ci-2024-q3-cicd-audit-story branch November 6, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: [2024-Q3] CI/CD Audit Story
3 participants