feat: fix wrong cache key on eth_getBlockByHash (#3232)
#3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebadiere
requested review from
AlfredoG87,
lukelee-sl and
a team
as code owners
* chore: fix wrong passed param Signed-off-by: nikolay <[email protected]> * chore: modify existing test to handle block_ properties as well Signed-off-by: nikolay <[email protected]> --------- Signed-off-by: nikolay <[email protected]> Signed-off-by: Eric Badiere <[email protected]>
ebadiere
force-pushed
the
3231-cherry-pick-cache-key-on-eth_getBlockByHash
branch
from
a835100 to
b299f27
Compare
|
Test Results 21 files + 1 266 suites ±0 35m 29s ⏱️ + 2m 31s For more details on these failures, see this check. Results for commit b299f27. ± Comparison against base commit 74ee9ec. ♻️ This comment has been updated with latest results. |
konstantinabl
approved these changes
Nov 7, 2024
quiet-node
approved these changes
Nov 7, 2024
natanasow
approved these changes
Nov 7, 2024
quiet-node
added
process
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.59 #3233 +/- ##
================================================
- Coverage 83.12% 82.84% -0.28%
================================================
Files 66 69 +3
Lines 4314 4477 +163
Branches 843 883 +40
================================================
+ Hits 3586 3709 +123
- Misses 485 518 +33
- Partials 243 250 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cherry-picked PR that fixes a cache key issue.
Related issue(s):
Fixes #3232