-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Updating workflows/actions to be compatible to and updating to the step-security maintained version. #2963
ci: Updating workflows/actions to be compatible to and updating to the step-security maintained version. #2963
Conversation
Test Results 3 files 297 suites 19s ⏱️ Results for commit 3d169d1. ♻️ This comment has been updated with latest results. |
@san-est needs a rebase but otherwise LG |
…ep-security maintained version. Signed-off-by: Vasil Boyadzhiev <[email protected]> Resolving conflicts and rebasing.
Signed-off-by: Vasil Boyadzhiev <[email protected]>
Signed-off-by: Vasil Boyadzhiev <[email protected]> Resolving conflicts and rebasing.
Signed-off-by: Vasil Boyadzhiev <[email protected]>
20c3d03
to
3d169d1
Compare
* chore: Move unneeded dependencies to `devDependencies` Signed-off-by: Victor Yanev <[email protected]> * chore: Move unneeded dependencies to `devDependencies` Signed-off-by: Victor Yanev <[email protected]> * chore: Move unneeded dependencies to `devDependencies` Signed-off-by: Victor Yanev <[email protected]> * Merge branch 'main' into 3035-Move-unneeded-dependencies-to-devDependencies Signed-off-by: Victor Yanev <[email protected]> * chore: move `@hashgraph/hedera-local` to `devDependencies` Signed-off-by: Victor Yanev <[email protected]> * chore: move `pnpm` Signed-off-by: Victor Yanev <[email protected]> --------- Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Nadezhda Popova <[email protected]>
@@ -40,7 +40,11 @@ jobs: | |||
timeout-minutes: 50 | |||
permissions: | |||
contents: write | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you have merge issues in this PR
@@ -100,8 +100,13 @@ jobs: | |||
networkTag: ${{inputs.networkNodeTag}} | |||
mirrorTag: ${{inputs.mirrorNodeTag}} | |||
|
|||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you have merge issues in this PR
@@ -135,6 +140,7 @@ jobs: | |||
networkTag: ${{inputs.networkNodeTag}} | |||
mirrorTag: ${{inputs.mirrorNodeTag}} | |||
|
|||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you have merge issues in this PR
fix: upgrade web3 from 4.12.1 to 4.13.0 Snyk has created this PR to upgrade web3 from 4.12.1 to 4.13.0. See this package in npm: web3 See this project in Snyk: https://app.snyk.io/org/json-rpc-relay/project/9e95a688-4e8c-4400-bbd9-181a47c69778?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: ebadiere <[email protected]> Co-authored-by: snyk-bot <[email protected]>
* feat: Wagmi example usage with Hedera Signed-off-by: mateuszm-arianelabs <[email protected]> * chore: typo in readme, remove unused import Signed-off-by: mateuszm-arianelabs <[email protected]> * chore: typo in readme, cleanup in code Signed-off-by: mateuszm-arianelabs <[email protected]> * chore: change pnpm to npm, small fixes Signed-off-by: mateuszm-arianelabs <[email protected]> * feat: pr suggestions applied Signed-off-by: Mariusz Jasuwienas <[email protected]> * feat: pr suggestions applied Signed-off-by: Mariusz Jasuwienas <[email protected]> * feat: cancuns opcodes are supported in hedera already so this comment about them was no longer valid Signed-off-by: Mariusz Jasuwienas <[email protected]> --------- Signed-off-by: mateuszm-arianelabs <[email protected]> Signed-off-by: Mariusz Jasuwienas <[email protected]> Co-authored-by: mateuszm-arianelabs <[email protected]>
* test: add helper method for overriding env variables Signed-off-by: Victor Yanev <[email protected]> * chore: improve readability Signed-off-by: Victor Yanev <[email protected]> * fix: usages Signed-off-by: Victor Yanev <[email protected]> * fix: cacheService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: utils.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: relay.spec.ts and sdkClient.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: eth_call.spec.ts, eth_estimateGas.spec.ts, ethGetBlockBy.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: use helper method to override envs in acceptance test specs Signed-off-by: Victor Yanev <[email protected]> * fix: hapiService.spec.ts and precheck.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: sdkClient.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: cacheService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: metricService.spec.ts and subscriptionController.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: rateLimiter.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: failing tests Signed-off-by: Victor Yanev <[email protected]> * chore: revert some changes in rpc_batch3.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: subscribe.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: add docs with examples to `overrideEnvs` and `withOverriddenEnvs` Signed-off-by: Victor Yanev <[email protected]> * chore: address comments Signed-off-by: Victor Yanev <[email protected]> * fix: build image test Signed-off-by: Victor Yanev <[email protected]> * Merge branch 'main' into add-helper-method-for-overriding-env-variables Signed-off-by: Victor Yanev <[email protected]> # Conflicts: # packages/relay/tests/lib/repositories/hbarLimiter/ethAddressHbarSpendingPlanRepository.spec.ts # packages/relay/tests/lib/repositories/hbarLimiter/hbarSpendingPlanRepository.spec.ts * chore: address comments + fix conflicts after merge Signed-off-by: Victor Yanev <[email protected]> * chore: optimize TTL tests in localLRUCache.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: failing unit test after merge from main Signed-off-by: Victor Yanev <[email protected]> * chore: optimize imports after merge from main Signed-off-by: Victor Yanev <[email protected]> --------- Signed-off-by: Victor Yanev <[email protected]>
… plans (#3058) * chore: refactor configurations of `HbarLimitService` Signed-off-by: Victor Yanev <[email protected]> * chore: fix ts errors Signed-off-by: Victor Yanev <[email protected]> * chore: revert formatting of table Signed-off-by: Victor Yanev <[email protected]> * refactor: configurations of `HbarLimitService` Signed-off-by: Victor Yanev <[email protected]> * Merge branch 'main' into 2970-Note-what-configurations-are-used Signed-off-by: Victor Yanev <[email protected]> # Conflicts: # packages/relay/src/lib/db/repositories/hbarLimiter/hbarSpendingPlanRepository.ts # packages/relay/src/lib/services/hbarLimitService/index.ts # packages/relay/tests/lib/services/hbarLimitService/hbarLimitService.spec.ts * docs: add configuration subsections to table of contents Signed-off-by: Victor Yanev <[email protected]> * docs: make descriptions of configurations consistent Signed-off-by: Victor Yanev <[email protected]> * chore: revert changes to localLRUCache.ts and redisCache.ts Signed-off-by: Victor Yanev <[email protected]> * chore: address comments Signed-off-by: Victor Yanev <[email protected]> * chore: address comments Signed-off-by: Victor Yanev <[email protected]> * chore: address comments Signed-off-by: Victor Yanev <[email protected]> * chore: address comments Signed-off-by: Victor Yanev <[email protected]> * chore: moves TODO comment to constants.ts Signed-off-by: Victor Yanev <[email protected]> * chore: optimize resetDate calculation Signed-off-by: Victor Yanev <[email protected]> * chore: remove unused imports Signed-off-by: Victor Yanev <[email protected]> * Merge branch 'main' into 2970-Note-what-configurations-are-used Signed-off-by: Victor Yanev <[email protected]> # Conflicts: # packages/relay/src/lib/db/repositories/hbarLimiter/ethAddressHbarSpendingPlanRepository.ts # packages/relay/src/lib/db/repositories/hbarLimiter/hbarSpendingPlanRepository.ts # packages/relay/src/lib/db/repositories/hbarLimiter/ipAddressHbarSpendingPlanRepository.ts # packages/relay/src/lib/services/hbarLimitService/index.ts # packages/relay/tests/lib/repositories/hbarLimiter/hbarSpendingPlanRepository.spec.ts # packages/relay/tests/lib/sdkClient.spec.ts # packages/relay/tests/lib/services/hbarLimitService/hbarLimitService.spec.ts * feat: Implement configuration to pre-populate the cache with spending plans Signed-off-by: Victor Yanev <[email protected]> * chore: address comments Signed-off-by: Victor Yanev <[email protected]> * chore: address comments Signed-off-by: Victor Yanev <[email protected]> * chore: address comments + added improvements to logic Signed-off-by: Victor Yanev <[email protected]> * chore: added tests + improvements to logic Signed-off-by: Victor Yanev <[email protected]> * docs: update docs Signed-off-by: Victor Yanev <[email protected]> * docs: reformat table Signed-off-by: Victor Yanev <[email protected]> * chore: improvements to hbarSpendingPlanConfigService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: fix typo Signed-off-by: Victor Yanev <[email protected]> * chore: revert unneeded changes Signed-off-by: Victor Yanev <[email protected]> * chore: censor IP addresses in logs of localLRUCache.ts and redisCache.ts Signed-off-by: Victor Yanev <[email protected]> * chore: censor IP addresses in logs of localLRUCache.ts and redisCache.ts Signed-off-by: Victor Yanev <[email protected]> * fix: hbarSpendingPlanRepository.spec.ts after resolving conflicts from main branch Signed-off-by: Victor Yanev <[email protected]> * fix: metricService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: fix wrong value for limit duration in `hbar-limiter.md` Co-authored-by: Logan Nguyen <[email protected]> Signed-off-by: Victor Yanev <[email protected]> * chore: fix jsdocs Co-authored-by: Logan Nguyen <[email protected]> Signed-off-by: Victor Yanev <[email protected]> * fix: hbarSpendingPlanRepository.ts Signed-off-by: Victor Yanev <[email protected]> * fix: ethAddressHbarSpendingPlanRepository.ts Signed-off-by: Victor Yanev <[email protected]> * fix: ipAddressHbarSpendingPlanRepository.ts Signed-off-by: Victor Yanev <[email protected]> * fix: jsdocs in hbarLimitService/index.ts Signed-off-by: Victor Yanev <[email protected]> * fix: do not reset metrics Signed-off-by: Victor Yanev <[email protected]> * Merge branch '2970-Note-what-configurations-are-used' into 3055-Implement-configuration-to-pre-populate-the-cache-with-spending-plans Signed-off-by: Victor Yanev <[email protected]> # Conflicts: # packages/relay/src/lib/db/repositories/hbarLimiter/hbarSpendingPlanRepository.ts # packages/relay/tests/lib/repositories/hbarLimiter/hbarSpendingPlanRepository.spec.ts * chore: remove mocks from hbarSpendingPlanConfigService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: remove mocks from hbarSpendingPlanConfigService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: delete obsolete IP and ETH address associations from the cache Signed-off-by: Victor Yanev <[email protected]> * chore: rename `SubscriptionType` to `SubscriptionTier` Signed-off-by: Victor Yanev <[email protected]> * chore: add jsdocs in hbarSpendingPlanConfigService.ts Signed-off-by: Victor Yanev <[email protected]> * chore: address sonar issue Signed-off-by: Victor Yanev <[email protected]> * chore: extend tests in relay.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: extend tests in server.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: extend tests in hbarSpendingPlanConfigService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: extend tests in hbarSpendingPlanConfigService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: reduce code duplication in hbarSpendingPlanConfigService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: remove unneeded mocks from hbarSpendingPlanConfigService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: extend tests in hbarSpendingPlanConfigService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: remove unused argument of helper method in hbarSpendingPlanConfigService.spec.ts Signed-off-by: Victor Yanev <[email protected]> * chore: move call of populatePreconfiguredSpendingPlans() back to constructor Signed-off-by: Victor Yanev <[email protected]> * chore: remove unused import Signed-off-by: Victor Yanev <[email protected]> * chore: address comments Signed-off-by: Victor Yanev <[email protected]> * chore: extend tests in localLRUCache.spec.ts and redisCache.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: case sensitivity in ethAddressHbarSpendingPlanRepository.ts Signed-off-by: Victor Yanev <[email protected]> * chore: only trace log when configuration file is missing Signed-off-by: Victor Yanev <[email protected]> * chore: log `Pre-configured spending plans populated successfully` only if any spending plans have been deleted or added Signed-off-by: Victor Yanev <[email protected]> * test: extend repository tests with new methods Signed-off-by: Victor Yanev <[email protected]> * test: extend relay.spec.ts Signed-off-by: Victor Yanev <[email protected]> * fix: failing unit tests Signed-off-by: Victor Yanev <[email protected]> * chore: use override envs helper method in tests Signed-off-by: Victor Yanev <[email protected]> --------- Signed-off-by: Victor Yanev <[email protected]> Signed-off-by: Victor Yanev <[email protected]> Co-authored-by: Logan Nguyen <[email protected]>
…REVERT but a BAD Request Response (#3088) * chore: add validation for even calldata length Signed-off-by: nikolay <[email protected]> * chore: add test coverage Signed-off-by: nikolay <[email protected]> --------- Signed-off-by: nikolay <[email protected]>
* fix: bugged metrics and wrong env vars Signed-off-by: Victor Yanev <[email protected]> * fix: jsdocs Signed-off-by: Victor Yanev <[email protected]> --------- Signed-off-by: Victor Yanev <[email protected]>
Add retry parameter and default public acceptance tests to 1 Signed-off-by: beeradb <[email protected]>
…in getTransferAmountSumForAccount() (#3103) Signed-off-by: Logan Nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove merge conflict tags
…ep-security maintained version. Signed-off-by: Vasil Boyadzhiev <[email protected]> Resolving conflicts and rebasing.
Signed-off-by: Vasil Boyadzhiev <[email protected]>
Signed-off-by: Vasil Boyadzhiev <[email protected]> Resolving conflicts and rebasing.
Signed-off-by: Vasil Boyadzhiev <[email protected]>
Signed-off-by: Vasil Boyadzhiev <[email protected]>
…ade-path-for-publish-unit-test-result-action' into 2943-determine-upgrade-path-for-publish-unit-test-result-action Signed-off-by: Vasil Boyadzhiev <[email protected]>
Signed-off-by: Vasil Boyadzhiev <[email protected]>
Quality Gate passedIssues Measures |
🚨 Memory Leak Detected 🚨A potential memory leak has been detected in the test titled Details📊 Memory Leak Detection Report 📊 GC Type: MarkSweepCompact Heap Statistics (before vs after executing the test):
Heap Space Statistics (before vs after executing the test):
RecommendationsPlease investigate the memory allocations in this test, focusing on objects that are not being properly deallocated. |
I will open a new PR for this task. |
New PR #3108 |
Description:
The previous attempt to upgrade to the step-security version of the workflows resulted in an issue as there was mismatch in the inputs between the versions. This should now be resolved and this PR contains the changed inputs as well as the upgrade to the step-security maintained version of the action.
Related issue(s):
Fixes #2943
Notes for reviewer:
Checklist