Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: parallelize PR checks and run only if relevant files are modified #566

Merged
merged 29 commits into from
Nov 28, 2023
Merged

chore: parallelize PR checks and run only if relevant files are modified #566

merged 29 commits into from
Nov 28, 2023

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Nov 17, 2023 •
edited by jeromy-cannon
Loading

Description

This pull request changes the following:

  • parallelize helm chart tests to reduce CI pipeline execution time (it is now ~9m compared to ~27m)
  • only run helm chart tests if related files are changed
  • only run fsnetman tests if related files are changed
  • fetch platform release artifact from https://builds.hedera.com
  • fetch NMT release artifact from https://builds.hedera.com
  • use NMT v1.2.2 instead of v2.0.0-alpha for testing as it is used in mainnet
  • use v0.42.5 platform version for chart tests instead of old v0.39.x

Related Issues

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2023 •
edited
Loading

Unit Test Results

  26 files  ±0    26 suites  ±0   51s ⏱️ -4s
109 tests ±0  105 ✔️ ±0  4 💤 ±0  0 ❌ ±0 
110 runs  ±0  106 ✔️ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 6f382ca. ± Comparison against base commit f2e2449.

♻️ This comment has been updated with latest results.

@leninmehedy leninmehedy force-pushed the parallelize-helm-chart-tests branch 2 times, most recently from 69882b2 to 4c123ad Compare November 17, 2023 22:52
@leninmehedy leninmehedy marked this pull request as ready for review November 17, 2023 23:18
@leninmehedy leninmehedy force-pushed the parallelize-helm-chart-tests branch 2 times, most recently from 19106da to c4a2cd3 Compare November 20, 2023 02:45
@leninmehedy leninmehedy changed the title chore: parallelize helm chart tests chore: parallelize helm chart tests to reduce PR checks duration Nov 20, 2023
@leninmehedy leninmehedy changed the title chore: parallelize helm chart tests to reduce PR checks duration ci: parallelize helm chart tests to reduce PR checks duration Nov 20, 2023
@leninmehedy leninmehedy changed the title ci: parallelize helm chart tests to reduce PR checks duration chore: parallelize helm chart tests to reduce PR checks duration Nov 20, 2023
@leninmehedy leninmehedy changed the title chore: parallelize helm chart tests to reduce PR checks duration chore: parallelize PR checks if relevant files are modified to reduce execution time Nov 20, 2023
@leninmehedy leninmehedy changed the title chore: parallelize PR checks if relevant files are modified to reduce execution time chore: parallelize PR checks and run only if relevant files are modified Nov 20, 2023
@leninmehedy leninmehedy self-assigned this Nov 20, 2023
@leninmehedy leninmehedy added the Improvement Code changes driven by non business requirements label Nov 20, 2023
@leninmehedy
ci: parallelize helm chart tests
abd68b6 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
ci: update step name
437819d 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
ci: update step name
e02c5d7 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
ci: add var step
7005459 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
ci: corrected step name
01ba980 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
ci: rename step for clarity
e39f868 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
fix: warning for readonly variables
2dee832 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
ci: rename steps
7892951 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
fix: fetch platform release artifact from builds.hedera.com
07ef4eb 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
fix: reuse function
a196f7f 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
style: fix lint error
5c460d4 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
fix: parsing minor version
479dc42 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
fix: create local dir to store artifacts
8ddb76c 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
fix: allow fetching NMT using gsutil
192ebab 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
ci: install gsutil for helm chart tests
2cb6207 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
fix: update platform version
a5a8ed5 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
fix: typo in bash script
c613aa9 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
fix: use is-system-running command to check if systemctl is running o…
f3955f5 
…r not

Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
fix: download nmt release from https://builds.hedera.com
6199524 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
fix: attempt to use systemctl list-jobs to check systemctl status
3878899 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
ci: no need to install gsutil for helm chart tests
8bafd71 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
ci: revert systemctl status check change for additional debug logs
fea1aa3 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
ci: only run helm chart tests if chart related files are changed
3eb9413 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
ci: fix variable name
f37c772 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
fix: create gc.log during node setup to support NMT v1.2.2
08a25ee 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
chore: only run fsnetman tests if relevant files are changed (#572)
d08bb5a 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy
ci: fix step name
2b107dd 
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy leninmehedy force-pushed the parallelize-helm-chart-tests branch from c2ecea8 to 2b107dd Compare November 27, 2023 00:24
@leninmehedy
style: fix lint errors
34cb3c7 
Signed-off-by: Lenin Mehedy <[email protected]>
nathanklick
nathanklick reviewed Nov 28, 2023
View reviewed changes
.github/workflows/flow-pull-request-checks.yaml Outdated Show resolved Hide resolved
.github/workflows/flow-pull-request-checks.yaml Outdated Show resolved Hide resolved
.github/workflows/flow-pull-request-checks.yaml Outdated Show resolved Hide resolved
.github/workflows/zxc-fsnetman-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/zxc-helm-chart-tests.yaml Outdated Show resolved Hide resolved
fullstack-network-manager/README.md Outdated Show resolved Hide resolved
fullstack-network-manager/README.md Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nathanklick nathanklick merged commit d9c04f2 into main Nov 28, 2023
16 checks passed
@nathanklick nathanklick deleted the parallelize-helm-chart-tests branch November 28, 2023 20:24
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanklick nathanklick nathanklick left review comments

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

Assignees

@leninmehedy leninmehedy

Labels
Improvement Code changes driven by non business requirements released
Projects
None yet
Milestone
No milestone
4 participants
@leninmehedy @swirlds-automation @jeromy-cannon @nathanklick