Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): use quote for test labels and fix e2e tests #560

Merged
merged 7 commits into from
Nov 17, 2023

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Nov 16, 2023

Description

This pull request changes the following:

  • use quote for test labels to support empty values
  • ci: use test-cache-dir to avoiding duplicate download of platform build.zip file

Related Issues

Copy link
Contributor

@qnswirlds qnswirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Thank you!

Copy link

github-actions bot commented Nov 16, 2023

Unit Test Results

  26 files  ±0    26 suites  ±0   1m 32s ⏱️ +28s
109 tests ±0  105 ✔️ ±0  4 💤 ±0  0 ±0 
110 runs  ±0  106 ✔️ ±0  4 💤 ±0  0 ±0 

Results for commit 3a04606. ± Comparison against base commit 38dd176.

♻️ This comment has been updated with latest results.

@leninmehedy leninmehedy changed the title fix(chart): use quote for test labels fix(chart): use quote for test labels and fix e2e tests Nov 16, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@leninmehedy leninmehedy merged commit 27fda90 into main Nov 17, 2023
18 checks passed
@leninmehedy leninmehedy deleted the 532-fix-test-labels branch November 17, 2023 01:04
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

swirlds-automation added a commit that referenced this pull request Nov 17, 2023
## [0.13.0](v0.12.0...v0.13.0) (2023-11-17)

### Features

* add a template for test labels ([#492](#492)) ([f32eaee](f32eaee))
* add cert-manager subchart to fullstack-cluster-setup Helm chart ([#493](#493)) ([674b976](674b976))
* add CI pipelines to enforce proper pull request titles ([#558](#558)) ([674ac32](674ac32))
* add envoy gateway to fullstack-cluster-setup helm chart ([#486](#486)) ([16988e4](16988e4))
* add test metadata labels for dependent charts ([#524](#524)) ([9511f1f](9511f1f))
* add test metadata to network-node-statefulset labels. ([#505](#505)) ([598eeaf](598eeaf))
* add test metadata to other resources labels ([#526](#526)) ([3762af1](3762af1))
* add test metadata to proxy resources labels ([#523](#523)) ([1067fc4](1067fc4))
* **cli:** implement node setup command ([#491](#491)) ([7920cb6](7920cb6))
* **cli:** implement package downloader and custom errors modules ([#490](#490)) ([8c143e9](8c143e9))
* **cli:** support config persistence and local chart directory for fst charts ([#535](#535)) ([73f7c1b](73f7c1b))
* implement node start and stop commands ([#520](#520)) ([9883fa7](9883fa7))

### Bug Fixes

* **chart:** use quote for test labels and fix e2e tests  ([#560](#560)) ([27fda90](27fda90))
* **cli:** init command should add FST helm chart repository ([#527](#527)) ([dc1e748](dc1e748))
* **cli:** invoke helm dependency update when local chart-dir is set ([#562](#562)) ([38dd176](38dd176))
* **cli:** kubectl version command errors out if server is un reachable ([#529](#529)) ([85ac118](85ac118))
* ensure Node package definitions are committed during a release ([#538](#538)) ([cbabf85](cbabf85))
* set namespace to kubectl context after cluster create ([#521](#521)) ([803ee4b](803ee4b))
* use correct variable name to check platform version ([#503](#503)) ([460a68e](460a68e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test metadata not displayed correctly
3 participants