fix user option form XML_DOCTYPE, apache#2744

hansva · Nov 12, 2024 · cd446e5 · cd446e5
1 parent 03f92b5
commit cd446e5
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/core/src/main/java/org/apache/hop/core/xml/XmlParserFactoryProducer.java b/core/src/main/java/org/apache/hop/core/xml/XmlParserFactoryProducer.java
@@ -22,6 +22,7 @@
 import javax.xml.parsers.ParserConfigurationException;
 import javax.xml.parsers.SAXParserFactory;
 import org.apache.hop.core.Const;
+import org.apache.hop.core.util.EnvUtil;
 import org.xml.sax.SAXNotRecognizedException;
 import org.xml.sax.SAXNotSupportedException;
 
@@ -37,13 +38,14 @@ private XmlParserFactoryProducer() {
    *
    * @throws ParserConfigurationException if feature can't be enabled
    */
+  @SuppressWarnings("java:S2755")
   public static DocumentBuilderFactory createSecureDocBuilderFactory()
       throws ParserConfigurationException {
     DocumentBuilderFactory docBuilderFactory = DocumentBuilderFactory.newInstance();
     docBuilderFactory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
     docBuilderFactory.setFeature(
         "http://apache.org/xml/features/disallow-doctype-decl",
-        "N".equals(Const.XML_ALLOW_DOCTYPE_DECL));
+        "N".equals(EnvUtil.getSystemProperty(Const.XML_ALLOW_DOCTYPE_DECL)));
 
     return docBuilderFactory;
   }