Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(함수랑함수몬): 초안 #1

Merged
merged 3 commits into from
Mar 17, 2024
Merged

Conversation

manudeli
Copy link
Member

@manudeli manudeli commented Mar 16, 2024

함수랑함수몬 초안

의도: 귀엽짜나

시연 영상

chrome-capture-2024-2-17

예정 작업

  • SVG로 홀로그램 따기
  • 최적화 버벅임 없애기
  • 홀로그램에 무지개빛깔 넣기
  • 카드 선택시 가운데로 쫘악 커지면서 함수몬 상세 페이지 Parallel Routes
  • SEO / 링크 이미지
  • 모바일 대응
  • 각자의 내용 추가받기
  • 배경에 별빛
  • 카드 뒷면 + 클릭 시 180도 회전

Copy link

vercel bot commented Mar 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
people ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2024 11:08am

@manudeli manudeli self-assigned this Mar 16, 2024
@manudeli manudeli marked this pull request as ready for review March 16, 2024 22:42
@manudeli manudeli changed the base branch from epic/함수랑함수몬 to main March 16, 2024 22:45
Copy link
Member

@sonsurim sonsurim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 혹시 Vercel은 마누 계정으루 연결되어 있나요?! 프리뷰 보고 싶은데 못보네유 ㅠㅜ

@manudeli
Copy link
Member Author

요거 혹시 Vercel은 마누 계정으루 연결되어 있나요?! 프리뷰 보고 싶은데 못보네유 ㅠㅜ

@tooooo1 계정으로 연결되어 있어요
아니면 main에 머지하고 볼까요?

Copy link
Member

@tooooo1 tooooo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋ와우 말하자마자 바로 나오다니 대박~~ㅋㅋ 너무 예쁘네요

Comment on lines +124 to +130
onMouseMove={(e) => {
const rect = e.currentTarget.getBoundingClientRect()
const centerX = rect.left + (rect.right - rect.left) / 2
const centerY = rect.top + (rect.bottom - rect.top) / 2
x.set(-(centerX - e.pageX))
y.set(-(centerY - e.pageY))
}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 아주잘되네용 ㅋㅋ
clone 받아서 실행해봤는데 버벅임이 좀 있어서 ㅠ 쓰로틀링이 필요해보이긴합니당

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(추후)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개선 고고

Comment on lines +65 to +71
const Card = ({
imageSrc,
name,
onTap,
orderFromCenter,
description,
}: Card & {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Card 컴포넌트랑 타입 이름 같은데 의도하신거에용?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 그러네요 나중에 이름 바꿉시담

apps/people/src/app/page.tsx Outdated Show resolved Hide resolved
Comment on lines +25 to +34
<Suspense clientOnly fallback={null}>
<Suspense
clientOnly
fallback={
<Flex.Center
width={320}
height={320}
overflow="hidden"
borderRadius="50%"
>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suspense clientOnly 상위에만 걸면 다르게 동작하나요 ?.?

Suggested change
<Suspense clientOnly fallback={null}>
<Suspense
clientOnly
fallback={
<Flex.Center
width={320}
height={320}
overflow="hidden"
borderRadius="50%"
>
<Suspense clientOnly fallback={null}>
<Suspense
fallback={
<Flex.Center
width={320}
height={320}
overflow="hidden"
borderRadius="50%"
>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clientOnly가 있으면 서버사이드렌더링에서 이 부분을 스킵해요. 그래서 나중에 이부분의 seo를 위한 처리가 필요합니담

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음 제가 말한건 그게 아니라 clientOnly가 중복으로 있어서용 상위에만 달면 하위도 clientOnly가 되는거 아닌가하는 질문이였슴당 ㅎㅎ 코드체인지에 그래서 제가 하위에는 clientOnly를 지웠던! ㅋㅋ Suspensive 라이브러리 질문이라 넘어가도됩니당 ㅋㅋ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아아 맞네요 하위에서 clientOnly가 필요 없을 거 같아요 리뷰 감사합니다

@manudeli
Copy link
Member Author

@sonsurim @tooooo1 일단 머지할게요. 차차 개선해가용

@manudeli manudeli merged commit c32ec56 into main Mar 17, 2024
6 checks passed
@okinawaa
Copy link

종현님 핵 쩌네요.. 대박 👍

@manudeli
Copy link
Member Author

종현님 핵 쩌네요.. 대박 👍

ㅎㅎ감사해요 빨리 개선하고 싶네요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants