-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(함수랑함수몬): 초안 #1
The head ref may contain hidden characters: "feat/\uD568\uC218\uB791\uD568\uC218\uBAAC-\uCD08\uC548"
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cc7151f
to
18e1a89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 혹시 Vercel은 마누 계정으루 연결되어 있나요?! 프리뷰 보고 싶은데 못보네유 ㅠㅜ
@tooooo1 계정으로 연결되어 있어요 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅋㅋㅋㅋ와우 말하자마자 바로 나오다니 대박~~ㅋㅋ 너무 예쁘네요
onMouseMove={(e) => { | ||
const rect = e.currentTarget.getBoundingClientRect() | ||
const centerX = rect.left + (rect.right - rect.left) / 2 | ||
const centerY = rect.top + (rect.bottom - rect.top) / 2 | ||
x.set(-(centerX - e.pageX)) | ||
y.set(-(centerY - e.pageY)) | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 아주잘되네용 ㅋㅋ
clone 받아서 실행해봤는데 버벅임이 좀 있어서 ㅠ 쓰로틀링이 필요해보이긴합니당
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(추후)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개선 고고
const Card = ({ | ||
imageSrc, | ||
name, | ||
onTap, | ||
orderFromCenter, | ||
description, | ||
}: Card & { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Card
컴포넌트랑 타입 이름 같은데 의도하신거에용?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 그러네요 나중에 이름 바꿉시담
<Suspense clientOnly fallback={null}> | ||
<Suspense | ||
clientOnly | ||
fallback={ | ||
<Flex.Center | ||
width={320} | ||
height={320} | ||
overflow="hidden" | ||
borderRadius="50%" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suspense clientOnly
상위에만 걸면 다르게 동작하나요 ?.?
<Suspense clientOnly fallback={null}> | |
<Suspense | |
clientOnly | |
fallback={ | |
<Flex.Center | |
width={320} | |
height={320} | |
overflow="hidden" | |
borderRadius="50%" | |
> | |
<Suspense clientOnly fallback={null}> | |
<Suspense | |
fallback={ | |
<Flex.Center | |
width={320} | |
height={320} | |
overflow="hidden" | |
borderRadius="50%" | |
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clientOnly가 있으면 서버사이드렌더링에서 이 부분을 스킵해요. 그래서 나중에 이부분의 seo를 위한 처리가 필요합니담
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음 제가 말한건 그게 아니라 clientOnly
가 중복으로 있어서용 상위에만 달면 하위도 clientOnly
가 되는거 아닌가하는 질문이였슴당 ㅎㅎ 코드체인지에 그래서 제가 하위에는 clientOnly
를 지웠던! ㅋㅋ Suspensive
라이브러리 질문이라 넘어가도됩니당 ㅋㅋ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아아 맞네요 하위에서 clientOnly가 필요 없을 거 같아요 리뷰 감사합니다
Co-authored-by: Chung-il Jung <[email protected]>
종현님 핵 쩌네요.. 대박 👍 |
ㅎㅎ감사해요 빨리 개선하고 싶네요 |
함수랑함수몬 초안
의도: 귀엽짜나
시연 영상
예정 작업