Restructures MarkdownParseOptions to expose extension selectors. #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halilozercan
reviewed
Dec 1, 2024
| import org.commonmark.ext.autolink.AutolinkExtension | ||
| import org.commonmark.ext.gfm.strikethrough.StrikethroughExtension | ||
| import org.commonmark.ext.gfm.tables.TablesExtension | ||
|
|
||
| /** | ||
| * Allows configuration of the Markdown parser | ||
| * | ||
| * @param autolink Detect plain text links and turn them into Markdown links. |
| public data class MarkdownParseOptions( | ||
| val autolink: Boolean | ||
| ) { | ||
| public data class MarkdownParseOptions(val extensions: List<Extension>) { |
There was a problem hiding this comment.
since richtext-commonmark and richtext-markdown are now separate modules I'm not as opposed to exposing commonmark details as I had been before, but I still would prefer if extensions were exposed as a value class.
value class MarkdownExtension private constructor(internal val value: Int) {
companion object {
val Tables = ...
val AutoLink = ...
...
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a need to add my own custom extensions to the parser and thought this could be a good generalization for everyone else.
This opens up
MarkdownParseOptionsto some flexibility in enabling or disabling extensions.