Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MbedTLS sign certificate #501

Merged
merged 7 commits into from
Apr 8, 2024
Merged

MbedTLS sign certificate #501

merged 7 commits into from
Apr 8, 2024

Conversation

huitema
Copy link
Collaborator

@huitema huitema commented Dec 4, 2023

No description provided.

@huitema huitema requested a review from kazuho December 4, 2023 02:33
@huitema
Copy link
Collaborator Author

huitema commented Dec 5, 2023

@kazuho the red flag in the test results comes from an appveyor issue, when running the 32 bit "debug" test:

Build started
git clone -q https://github.com/h2o/picotls.git C:\projects\picotls
fatal: unable to access 'https://github.com/h2o/picotls.git/': Failed to connect to github.com port 443: Timed out
Command exited with code 128

I have seen that on a couple occasions with Picoquic. Just restarting the test would fix it, but I think I don't have the permission to do that in the picotls depot. In any case, the 32 bit "release" test works, as well as the 64 bit "debug" test, so we are very unlikely to find an issue.

@kazuho kazuho mentioned this pull request Apr 8, 2024
@kazuho kazuho merged commit 2dbc09e into h2o:master Apr 8, 2024
10 checks passed
@kazuho
Copy link
Member

kazuho commented Apr 8, 2024

Thank you for the PR. Merged as #517.

@huitema huitema deleted the mbed-tls-sign-certificate branch April 8, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants