Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jhonesto: Final submission. #671

Closed
wants to merge 4 commits into from
Closed

Conversation

jhonesto
Copy link

Check List:

  • You have run ./mvnw verify and the project builds successfully
  • Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
  • All formatting changes by the build are committed
  • Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
  • Output matches that of calculate_average_baseline.sh
  • [x ] For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (393)
  • Execution time: 5.627 s
  • Execution time of reference implementation: 3m20.823s


Measurement m = table.get(hash);

if (m != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where you’ll need to implement a method that checks if the object at the found hash is the actual object you’re looking for.

Having just the hash match isn’t allowed in this contest; if it was staying below the 2 seconds would be easy.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much Roy!

Now it's clear to me. I was thinking in a completely opposite direction.

Should I close this pull request?

And What timezone are you using? Because, I am in UTC-3 and have other things to do here.
I'm not sure if I can deliver on time.

I really appreciate your help.

@gunnarmorling
Copy link
Owner

Similar to the original entry, this is prone to hash collisions.

@gunnarmorling
Copy link
Owner

Going to close this one, as we haven't heard back within a couple of days and we're after the cut-off time now. Thx a lot for your efforts nevertheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants