Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Justin's implementation #666

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Conversation

Judekeyser
Copy link
Contributor

@Judekeyser Judekeyser commented Jan 30, 2024

Check List:

  • You have run ./mvnw verify and the project builds successfully
  • Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
  • All formatting changes by the build are committed
  • Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
  • Output matches that of calculate_average_baseline.sh
  • For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number)
  • Execution time: 21 seconds
  • Execution time of reference implementation: 220 seconds

On my machine, runtime greatly varies from 1.8 seconds to 2.7 seconds (most of the time, around 21)

@Judekeyser
Copy link
Contributor Author

Nothing new ; I just scaled down the number of NIO workers. All usual checks are good

@gunnarmorling
Copy link
Owner

00:14.900.

@gunnarmorling gunnarmorling merged commit 711aa23 into gunnarmorling:main Jan 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants