Update seijikun implementation

[seijikun]

Updated with

• SIMD for station name parsing
• Fewer String allocations
• Moved from double to integer maths

[gunnarmorling]

Hey, could you please rebase this one and also make sure all the tests pass (added those today to cover some corner cases):

./test.sh seijikun

Thx!

[seijikun]

Hey, could you please rebase this one and also make sure all the tests pass (added those today to cover some corner cases):

./test.sh seijikun

Thx!

Okay, done! Tests seem to succeed

[gunnarmorling]

Hum, hum, I still see failures:

Validating calculate_average_seijikun.sh -- src/test/resources/samples/measurements-10.txt
WARNING: Using incubator modules: jdk.incubator.vector
java.lang.IllegalArgumentException: Negative size
	at java.base/sun.nio.ch.FileChannelImpl.mapInternal(FileChannelImpl.java:1255)
	at java.base/sun.nio.ch.FileChannelImpl.map(FileChannelImpl.java:1186)
	at dev.morling.onebrc.CalculateAverage_seijikun$ChunkReader.run(CalculateAverage_seijikun.java:183)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
java.io.IOException: Channel not open for writing - cannot extend file to required size
	at java.base/sun.nio.ch.FileChannelImpl.mapInternal(FileChannelImpl.java:1285)
	at java.base/sun.nio.ch.FileChannelImpl.map(FileChannelImpl.java:1186)
	at dev.morling.onebrc.CalculateAverage_seijikun$ChunkReader.run(CalculateAverage_seijikun.java:183)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
java.io.IOException: Channel not open for writing - cannot extend file to required size
	at java.base/sun.nio.ch.FileChannelImpl.mapInternal(FileChannelImpl.java:1285)
	at java.base/sun.nio.ch.FileChannelImpl.map(FileChannelImpl.java:1186)
	at dev.morling.onebrc.CalculateAverage_seijikun$ChunkReader.run(CalculateAverage_seijikun.java:183)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)

real	0m0.192s
user	0m0.363s
sys	0m0.059s
1c1
< {Adelaide=15.0/15.0/15.0, Cabo San Lucas=14.9/14.9/14.9, Dodoma=22.2/22.2/22.2, Halifax=12.9/12.9/12.9, Karachi=15.4/15.4/15.4, Pittsburgh=9.7/9.7/9.7, Ségou=25.7/25.7/25.7, Xi'an=24.2/24.2/24.2, Zagreb=12.2/12.2/12.2}
---
> {Adelaide=15.0/15.0/15.0, Cabo San Lucas=14.9/14.9/14.9, Dodoma=22.2/22.2/22.2, Halifax=12.9/12.9/12.9, Karachi=15.4/15.4/15.4, Pittsburgh=9.7/9.7/9.7, Ségou=25.7/25.7/25.7, Tauranga=38.2/38.2/38.2, Xi'an=24.2/24.2/24.2, Zagreb=12.2/12.2/12.2}

[seijikun]

Whoops, sorry! You're right.
The bug depended on the amount of cores in the test machine. I rewrote the chunking logic to now be hopefully much more robust.

[gunnarmorling]

00:22.709 now, thx for participating!