First submission for Reed Thorngag #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
something is wrong with the calculations, if you compare them to the reference implementation |
|
Shamelessly sharing this idea for JVM/GC tuning in another PR/discussion? #15 (comment) |
|
ah whoops, I forgot to test it after I "fixed" it lol, mb |
|
LOL its not reading the full input file, I'll try work out why and fix it, but it means the time will be a lot higher haha |
|
Hey, I'm gonna close this one as it has been in Draft state for a week and I need to clean the slate a bit. Please feel free to re-open (rebased to current main, passing all the latest tests etc.) once you're ready to submit. Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mine: 0m4.909s
base: 3m27.670s
Its pretty bad and unoptimized, I'll try fix it up a bit at some point and optimize it a bit more.