-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve scheduling for thomaswue #358
Conversation
It doesn't seem to move the needle on the eval machine:
|
This is great! Also someone mentioning JDK tickets somewhere. So great to see these improvements as a fallout of this! |
OK, thanks for evaluating! Looks like this is starting to get quite machine-specific now. |
Yepp, absolutely. It might be as far as we get for now, which is waaay beyond whatever I had been expecting before. Let's see whether someone manages to pull out a surprise bunny out of their hat between now and Jan 31 ;) |
@gunnarmorling No stress evaluating this, but now I fixed a problem in the hash calculation (which even led to a collision for the test data set) and improved the performance for the new 10k cities test substantially by being a bit better in case of actual collisions. The performance gain on my machine was another 3% over the previous version for the original test data and I have now runs slightly below 0.60s there. |
00:02.552 now on the official data set. I.e. a teenie-tiny bit ahead @merykitty's recorded unsafe entry. So close in fact that I can't identify a clear ordering with the current way of measuring. I'm therefore putting both with #1 into the leaderboard for now. I don't think the order matters an awful lot, as the learning experience is the most important outcome here.
|
Yes, agreed, thank you! |
Check List:
./test.sh <username>
shows no differences between expected and actual outputs)calculate_average_<username>.sh
(make sure to match casing of your GH user name) and is executablecalculate_average_baseline.sh
Already filing enhancement requests for the GraalVM compiler scheduler. Apparently this innocent looking change gains 6%+ ;-).