Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic table columns feature #344

Closed
wants to merge 1 commit into from

Conversation

SuchiraD
Copy link
Contributor

@SuchiraD SuchiraD commented Jan 2, 2024

Added looping for table columns.

Eg:
Dynamic columns
image

image

Dynamic rows & dynamic columns
image

image

Ran `jest --updateSnapshot` to fix error_handling.test.ts.snap
@SuchiraD
Copy link
Contributor Author

SuchiraD commented Jan 2, 2024

Hey @jjhbw, I have made few changes to enable dynamic generation of table columns. Please suggest any test cases that I should add, which will cover any edge case if there is any.

@jjhbw
Copy link
Collaborator

jjhbw commented Jan 12, 2024

Good to see someone finally took a stab at this! Thanks a lot for the effort.

Sorry for taking so long to respond to this, I have been meaning to test it against a few private test cases first to ensure we're not introducing regressions (the docx spec is terrifying, as you may know very well by now haha).

@SuchiraD
Copy link
Contributor Author

Good to see someone finally took a stab at this! Thanks a lot for the effort.

Sorry for taking so long to respond to this, I have been meaning to test it against a few private test cases first to ensure we're not introducing regressions (the docx spec is terrifying, as you may know very well by now haha).

Hahaha.... absolutely. It is too complicated.

Yes please. Its always better to look at this in another perspective. Maybe I could have been biased only for the repetition of table columns.

@SuchiraD
Copy link
Contributor Author

SuchiraD commented Mar 9, 2024

Hi @jjhbw,
Do you have any idea on what scenarios should I write more test cases to?

@jjhbw
Copy link
Collaborator

jjhbw commented Apr 1, 2024

Working on your PR now.

Sidenote:

Ran jest --updateSnapshot to fix error_handling.test.ts.snap

Note that these snapshots weren't broken, they were just geared towards Node 20.x, which has slightly different error messages than older versions.

@jjhbw
Copy link
Collaborator

jjhbw commented Apr 1, 2024

Thanks! Looks great.

Merged offline 13b40c3

@jjhbw jjhbw closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants