Add AES-256-GCM support to the new protocol #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsliepen
force-pushed
the
feature/alt-ciphersuite
branch
from
9669def to
485108a
Compare
gsliepen
force-pushed
the
feature/alt-ciphersuite
branch
from
485108a to
f4db140
Compare
gsliepen
added
enhancement
This also adds a simple cipher suite negotiation, where peers announce the ciphers they support, and their preferred cipher. Since we need to bump the SPTPS version anyway, also prefer little endian over network byte order.
…ersion. This is necessary so our copy of Chacha20-Poly1305 is compatible with that of many other crypto libraries. This code is made by Grigori Goronz, but is heavily based on the code from D.J. Bernstein's ref10 implementation used before.
Remove mentions of it from the documentation, but keep supporting the option for now, as this makes it easier to test compatibility with the legacy protocol.
The crypto library on Windows exposes a symbol named poly1305_init(), which clashes with ours. We can avoid this by moving poly1305_get_tag() to poly1305.[ch], where it belongs better, and this allows us to make all the lower-level Poly1305 functions static. Also remove the support for associated data while we are at it, since we are never using it.
gsliepen
force-pushed
the
feature/alt-ciphersuite
branch
from
f4db140 to
e994222
Compare
|
This is still a big blocker for us in moving to 1.1 from 1.0 It looks like there is now cipher selection / negotiation. Whats blocking? The test logs don't exist any more so perhaps @gsliepen can enlighten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.