Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cssmin.js #273

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update cssmin.js #273

wants to merge 1 commit into from

Conversation

MathijsvVelde
Copy link

Added callback to CleanCSS.minify function

I got this warning every time I used grunt-contrib-cssmin to combine multiple css files:

>> Ignoring remote @import of "https://fonts.googleapis.com/css?family=Roboto:300,400,400i,500,700,700i|Montserrat:400,700" as no callback given.

So I added the callback, and it works!! 👍

@MathijsvVelde
Update cssmin.js
3e7750a 
Added callback to CleanCSS.minify function
@XhmikosR
Copy link
Member

/CC @shama @vladikoff

@XhmikosR
Copy link
Member

/CC @jakubpawlowicz: is this still valid with v4?

@scyzemic
Copy link

scyzemic commented Mar 3, 2017

Is this going to be merged? This is still an issue

@XhmikosR
Copy link
Member

This needs a test case to verify the fix.

Base automatically changed from master to main March 22, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MathijsvVelde @XhmikosR @scyzemic