Add base64 encoded api_token as basic auth header to JobBoard#apply_to_job method #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o_job method, and update fixtures
Ryman
reviewed
Jul 3, 2018
| @@ -54,6 +54,10 @@ def get_from_job_board_api(url, options = {}) | |||
| end | |||
| end | |||
|
|
|||
| def post_headers | |||
| { 'Authorization' => 'Basic ' + Base64.encode64(api_token), 'Content-Type' => 'application/json' } | |||
There was a problem hiding this comment.
Shouldn't it be the base64 of api_token + ':' ? (to be a username with no password)
There was a problem hiding this comment.
I won't disagree with you - I will test when I get a chance.
Just working from the API docs https://github.com/grnhse/greenhouse-api-docs/blob/master/source/includes/job-board/_applications.md#request-headers
and it seems to work fine without.
|
@capablemonkey can somebody at Greenhouse review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POST requests to Job Applications endpoint require api_token to be base64 encoded, and Content-Type to be set as 'application/json'.
Being able to run specs required updating webmock version and codeclimate ruby-test-reporter config.