Reflection-less Index generation [Upto 70% improvement in performance] #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@greenrobot-team : The build seems to be failing with 1 lint issue though it passes for me. We have tried to fix the build breakage on the master here with these fixes as well. We do not have access to the travis logs for lint warnings for us to be able to action it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While generating the Subscriber indices there is an opportunity to do away with reflection.
Using the interface SubscriberMethodInvoker anonymous classes are generated which access the public methods of the class directly.
Older implementation :
New Implementation :