Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grayscale to palette, add as button color #991

Open
wants to merge 16 commits into
base: release-146
Choose a base branch
from

Conversation

gigxz
Copy link
Collaborator

@gigxz gigxz commented Dec 8, 2024

Description

Issue: https://github.com/open-path/Green-River/issues/7130
Chromatic: Link

This PR is a refactor of "gray" buttons in the app, to match the hmis design library.

  • Add grayscale color palette per design library
  • Replace usage of old gray button variant color color=grayscale variant=contained
  • Replace usage of old transparent button variant with color=grayscale variant=text
  • Update TODOs
  • Add button variant/color stories
  • Remove default white background from outlined buttons per figma change (see https://github.com/open-path/Green-River/issues/7130#issuecomment-2560383390). This allows them to be used on alerts correctly.

Type of change

  • Code clean-up / housekeeping

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • My code includes comments and/or descriptive variable names to help other engineers understand the intent (or not applicable)
  • My code follows the style guidelines of this project (eslint)
  • I have updated the documentation (or not applicable)
  • If it's not obvious how to test this change, I have provided testing instructions in this PR or the related issue

@gigxz gigxz changed the title Gig/grayscale button Add grayscale to palette, add as button color Dec 9, 2024
@gigxz gigxz mentioned this pull request Dec 13, 2024
8 tasks
@gigxz gigxz changed the base branch from release-144 to release-146 December 23, 2024 22:19
@gigxz gigxz marked this pull request as ready for review December 23, 2024 22:33
@gigxz gigxz requested review from martha and ttoomey December 24, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant