Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - adjust Info Group width #714

Draft
wants to merge 1 commit into
base: stable
Choose a base branch
from
Draft

WIP - adjust Info Group width #714

wants to merge 1 commit into from

Conversation

gigxz
Copy link
Collaborator

@gigxz gigxz commented Mar 27, 2024

Description

Attempt to fix info group. Previously it relied on width: 'fit-content',, since Inputs used to have a minimum width. Thats not the case anymore, so it squishes together inputs.

This approach makes it full -width, which also doesn't look ideal. Needs some more hacking / design review. The "info group" was originally designed for the Data Quality fields. It is now in use in one other place, for describing the PLS breaks.

Screenshot 2024-03-27 at 10 04 39 AM Screenshot 2024-03-27 at 10 04 29 AM

Type of change

  • Bug fix
  • New feature (adds functionality)
  • Code clean-up / housekeeping
  • Dependency update

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • My code includes comments and/or descriptive variable names to help other engineers understand the intent (or not applicable)
  • My code follows the style guidelines of this project (eslint)
  • I have updated the documentation (or not applicable)
  • If it's not obvious how to test this change, I have provided testing instructions in this PR or the related issue

@gigxz gigxz requested a review from martha March 27, 2024 14:08
@martha
Copy link
Contributor

martha commented Mar 27, 2024

@gigxz I agree about your idea to set this aside for now, I just wanted to add while I'm thinking about it and checking out your code, that maybe one thing we could do is to add a max width on the parent grid? Also, we could consider adding min width back on the inputs? (we just have to remember to remove it on mobile.)

@gigxz gigxz changed the base branch from release-109 to release-110 March 29, 2024 13:55
Base automatically changed from release-110 to stable April 4, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants