Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear button focusable for select #1003

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

martha
Copy link
Contributor

@martha martha commented Dec 20, 2024

Description

GH issue: https://github.com/open-path/Green-River/issues/7004, specifically https://github.com/open-path/hmis-accessibility/issues/37

This doesn't address all a11y issues with MUI's Autocomplete component; see issue description on 37 for additional topics to discuss.

Type of change

  • Bug fix
  • New feature (adds functionality)
  • Code clean-up / housekeeping
  • Dependency update
  • Accessibility update

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • My code includes comments and/or descriptive variable names to help other engineers understand the intent (or not applicable)
  • My code follows the style guidelines of this project (eslint)
  • I have updated the documentation (or not applicable)
  • If it's not obvious how to test this change, I have provided testing instructions in this PR or the related issue

@martha martha requested a review from gigxz December 20, 2024 03:05
Copy link
Collaborator

@gigxz gigxz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@gigxz gigxz merged commit ffb1ec2 into release-146 Dec 20, 2024
3 checks passed
@gigxz gigxz deleted the martha/7004-a11y-autocomplete branch December 20, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants