Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route 13 Match Success Contact Actor #888

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Route 13 Match Success Contact Actor #888

merged 2 commits into from
Dec 4, 2024

Conversation

dtgreiner
Copy link
Contributor

Merging this PR

  • use the squash-merge strategy for PRs targeting a release-X branch
  • use a merge-commit or rebase strategy for PRs targeting the stable branch

Description

Fixes an issue in Route 13 when the HSA contact accepts the match and is met with an error page.

Type of change

Bug fix

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • I have updated the documentation (or not applicable)
  • I have added spec tests (or not applicable)
  • I have provided testing instructions in this PR or the related issue (or not applicable)

@dtgreiner dtgreiner requested a review from eanders December 4, 2024 18:20
@eanders eanders changed the base branch from release-70 to release-71 December 4, 2024 21:12
@eanders eanders merged commit f91f752 into release-71 Dec 4, 2024
17 checks passed
@eanders eanders deleted the dg/router_13_hsa_accept_match_error-6997 branch December 4, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eanders eanders eanders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtgreiner @eanders