Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up unused match decision reasons #872

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

dtgreiner
Copy link
Contributor

Merging this PR

  • use the squash-merge strategy for PRs targeting a release-X branch
  • use a merge-commit or rebase strategy for PRs targeting the stable branch

Description

Remove unreferenced MatchDecisionReasons classes & cleanup unused code in referenced classes.

Type of change

Code clean-up

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • I have updated the documentation (or not applicable)
  • I have added spec tests (or not applicable)
  • I have provided testing instructions in this PR or the related issue (or not applicable)

@dtgreiner dtgreiner requested a review from eanders October 29, 2024 17:25
@eanders eanders changed the base branch from release-67 to release-68 October 29, 2024 18:18
Copy link
Contributor

@eanders eanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dtgreiner !

@eanders eanders merged commit c266b33 into release-68 Oct 29, 2024
16 of 17 checks passed
@eanders eanders deleted the dg/unused_match_decisions-6548 branch October 29, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants