Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tab for archived vouchers within a program's vouchers/units #867

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

dtgreiner
Copy link
Contributor

@dtgreiner dtgreiner commented Oct 17, 2024

Please squash merge this PR

Description

Add a new tab in the Program's Vouchers/Units section to show the archived vouchers. These vouchers can now be restored.

Screenshot 2024-10-17 at 9 42 43 AM

Type of change

  • New feature (adds functionality)

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • My code includes comments and/or descriptive variable names to help other engineers understand the intent (or not applicable)
  • My code follows the style guidelines of this project (rubocop)
  • I have updated the documentation (or not applicable)
  • If it's not obvious how to test this change, I have provided testing instructions in this PR or the related issue

@dtgreiner dtgreiner requested a review from eanders October 17, 2024 13:43
Copy link
Contributor

@eanders eanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dtgreiner this looks great, thank you. Just one minor tweak to cover an edge case I can see coming up.

@eanders eanders merged commit 79a44fd into release-67 Oct 22, 2024
15 of 17 checks passed
@eanders eanders deleted the dg/missing_voucher-6794 branch October 22, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants