Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CE Events from CAS Matches #862

Merged
merged 3 commits into from
Sep 23, 2024
Merged

CE Events from CAS Matches #862

merged 3 commits into from
Sep 23, 2024

Conversation

eanders
Copy link
Contributor

@eanders eanders commented Sep 22, 2024

Please squash merge this PR

Description

WIP

This corrects some assumptions for canceled and declined matches and how they generate referral events. Specifically, canceled matches were not identifying the reason for CE reporting correctly, and matches that didn't end with a decline, but which were declined, couldn't always find their reasons.

Type of change

  • Bug fix

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • My code includes comments and/or descriptive variable names to help other engineers understand the intent (or not applicable)
  • My code follows the style guidelines of this project (rubocop)
  • I have updated the documentation (or not applicable)
  • If it's not obvious how to test this change, I have provided testing instructions in this PR or the related issue

@eanders eanders requested a review from dtgreiner September 23, 2024 14:15
@eanders eanders merged commit 2ddb400 into release-64 Sep 23, 2024
14 of 16 checks passed
@eanders eanders deleted the ea/ce-events branch September 23, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants