Updates from code review

app/models/match_decisions/eleven/eleven_confirm_hsa_accepts_client_decline_dnd_staff.rb

@@ -7,7 +7,7 @@
 module MatchDecisions::Eleven
   class ElevenConfirmHsaAcceptsClientDeclineDndStaff < ::MatchDecisions::Base
     def to_partial_path
-      'match_decisions/eleven_confirm_hsa_accepts_client_decline_dnd_staff'
+      'match_decisions/eleven/confirm_hsa_accepts_client_decline_dnd_staff'
     end
 
     def statuses
@@ -67,7 +67,8 @@ def notifications_for_this_step
     end
 
     def accessible_by? contact
-      contact.user_can_reject_matches? || contact.user_can_approve_matches?
+      contact.user_can_reject_matches? ||
+      contact.user_can_approve_matches?
     end
 
     def show_client_match_attributes?
@@ -90,7 +91,6 @@ def decline_overridden_returned
 
       def decline_confirmed
         match.rejected!
-        # TODO maybe rerun the matching engine for that vacancy and client
       end
 
       def canceled

app/models/match_decisions/eleven/eleven_hsa_accepts_client.rb

@@ -7,7 +7,7 @@
 module MatchDecisions::Eleven
   class ElevenHsaAcceptsClient < ::MatchDecisions::Base
     def to_partial_path
-      'match_decisions/eleven_hsa_accepts_client'
+      'match_decisions/eleven/hsa_accepts_client'
     end
     include MatchDecisions::AcceptsDeclineReason
 
@@ -88,7 +88,7 @@ def notify_contact_of_action_taken_on_behalf_of contact: # rubocop:disable Lint/
 
     def accessible_by? contact
       contact.user_can_act_on_behalf_of_match_contacts? ||
-      contact.in?(match.housing_subsidy_admin_contacts)
+      contact.in?(match.send(contact_actor_type))
     end
 
     def show_client_match_attributes?

app/models/match_decisions/eleven/eleven_hsa_acknowledges_receipt.rb

@@ -7,7 +7,7 @@
 module MatchDecisions::Eleven
   class ElevenHsaAcknowledgesReceipt < ::MatchDecisions::Base
     def to_partial_path
-      'match_decisions/eleven_hsa_acknowledges_receipt'
+      'match_decisions/eleven/hsa_acknowledges_receipt'
     end
 
     validate :cant_accept_if_match_closed
@@ -37,7 +37,7 @@ def actor_type
     end
 
     def contact_actor_type
-      nil
+      :housing_subsidy_admin_contacts
     end
 
     def statuses
@@ -66,8 +66,8 @@ def initialize_decision! send_notifications: true
     end
 
     def accessible_by? contact
-      contact.user_can_act_on_behalf_of_match_contacts? ||
-      contact.in?(match.housing_subsidy_admin_contacts)
+      contact.user_can_act_on_behalf_of_match_contacts?
+      contact.in?(match.send(contact_actor_type))
     end
 
     def notifications_for_this_step

app/models/match_routes/eleven.rb

@@ -56,7 +56,7 @@ def status_declined?(match)
     end
 
     def contact_label_for(contact_type)
-      case contact_type
+      case contact_type&.to_sym
       when :dnd_staff_contacts
         Translation.translate('CoC Eleven')
       when :housing_subsidy_admin_contacts

app/views/notifications_mailer/eleven_match_initiation_for_hsa.text.haml

@@ -2,7 +2,7 @@ Hello #{@contact.full_name},
 \
 The CAS has generated a new match recommendation.  
 \
-Please acknowledge receipt of this match and review the associated HSA contacts.
+Please acknowledge receipt of this match and review the associated #{Translation.translate('HSA Eleven')} contacts.
 \
 Please review details:
 #{notification_match_url @notification, @match}

app/views/notifications_mailer/hsa_decision_client.text.haml

@@ -2,7 +2,7 @@ Hello #{@contact.full_name},
 \
 = "A #{Translation.translate('Housing Subsidy Administrator')} has made a decision on a housing opportunity for which the client below applied."
 \
-Decision: #{@match.eleven_hsa_accepts_client_decision.status_label}
+Decision: #{@match.hsa_accepts_client_decision.status_label}
 \
 = render 'client_details'
 \

app/views/notifications_mailer/hsa_decision_hsp.text.haml

@@ -2,7 +2,7 @@ Hello #{@contact.full_name},
 \
 = "A #{Translation.translate('Housing Subsidy Administrator')} has made a decision on a housing opportunity for which the client below applied."
 \
-Decision: #{@match.eleven_hsa_accepts_client_decision.status_label}
+Decision: #{@match.hsa_accepts_client_decision.status_label}
 \
 View details here:
 #{notification_match_url @notification, @match}

app/views/notifications_mailer/hsa_decision_shelter_agency.text.haml

@@ -2,7 +2,7 @@ Hello #{@contact.full_name},
 \
 = "A #{Translation.translate('Housing Subsidy Administrator')} has made a decision on a housing opportunity for which the client below applied."
 \
-Decision: #{@match.eleven_hsa_accepts_client_decision.status_label}
+Decision: #{@match.hsa_accepts_client_decision.status_label}
 \
 View details here:
 #{notification_match_url @notification, @match}

app/views/notifications_mailer/hsa_decision_ssp.text.haml

@@ -2,7 +2,7 @@ Hello #{@contact.full_name},
 \
 = "A #{Translation.translate('Housing Subsidy Administrator')} has made a decision on a housing opportunity for which the client below applied."
 \
-Decision: #{@match.eleven_hsa_accepts_client_decision.status_label}
+Decision: #{@match.hsa_accepts_client_decision.status_label}
 \
 View details here:
 #{notification_match_url @notification, @match}