-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt Docker setup to latest changes #5045
base: master
Are you sure you want to change the base?
Conversation
Many thanks for working on this. Some minor comments from giving it a test run:
It would be useful to add that that downloading and importing the water polygons table can take substantial time, and will be the rate limiting step when importing a small subset of OSM data (which will be the normal use case). It doesn't help that the message shown by On the first run, import failed with "Max retries exceeded with url: /download/antarctica-icesheet-outlines-3857.zip (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0x7f345affb7d0>: Failed to resolve 'osmdata.openstreetmap.de", which is odd because the website was functioning. It worked on repeating the [Haven't tested beyond the font import step. This fails with "scripts/get-fonts.sh: 11: curl: not found".] |
a6e8c17
to
7a32a2b
Compare
And use newer versions of base images.
7a32a2b
to
0d04886
Compare
I have added a few more log message to help with tracking the import process, and mentioned the external data download in The latest version can now go through the import process without having to apply more patches. Noto Emoji is downloaded from the Internet Archive using the file @pjduplooygis has uploaded earlier this year. And because fonts are downloaded separately during the import process, they have been removed from the package list in the Dockerfile. I don’t really want to go much further regarding fonts, as it isn’t the main topic of this PR. |
Have now confirmed this works when merged with #4893. The (existing) instructions about setting environment variables e.g. to adjust the behaviour of |
Fixes #5031, #5005.
Requires #4893, or any other solution for #5043.
The Docker setup is a quick and easy way to get an Openstreetmap-carto dev environment running, so it’s probably worth keeping it in a working state. This PR updates the startup script to take recent changes into account, such as #4978. It also updates the base images to more recent versions.
With this PR alone, setting up the containers fails because fonts cannot be downloaded. Applying #4893 allows testing the whole setup.