Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for tourism=wilderness_hut #2279

Closed

Conversation

Ircama
Copy link
Contributor

@Ircama Ircama commented Aug 13, 2016

Add rendering of tag tourism=wilderness_hut
[Edited summary for this PR, left it out on my first push]
The aim of this PR is to propose a rendering for the tag tourism=wilderness_hut as suggested in the Wiki at
http://wiki.openstreetmap.org/wiki/Tag:tourism%3Dwilderness_hut
and as per related rendering proposal at
http://wiki.openstreetmap.org/wiki/Proposed_features/wilderness_mountain_buildings#Rendering

It references issue #540 and attempts to improve unmerged PRs #2140, #2144 and #2145. Over the last unmerged commit, the differences are:

  • Removed usage of shelter_type, which can be introduced again when hstore is available
  • Removed basic_hut.svg, to be used with shelter_type
  • Rebase to master

To summarize, the following different kind of huts have specific symbols now:

  • amenity=shelter (only shown at zoom >=16)
  • tourism=alpine_hut (not modified within this drop)
  • tourism=wilderness_hut (zoom>=13)

alpine_hut: symbols/alpinehut.p.16.png
wilderness_hut: symbols/wilderness_hut.svg
generic shelter: symbols/shelter.svg

Resolves #540

@matthijsmelissen
Copy link
Collaborator

Is it just me, or is there something wrong with the SVG? It doesn't seem properly centered.

@pnorman
Copy link
Collaborator

pnorman commented Aug 22, 2016

Is it just me, or is there something wrong with the SVG? It doesn't seem properly centered

It's not just you.

@pnorman
Copy link
Collaborator

pnorman commented Aug 22, 2016

With only 2.2k uses I'm against adding an icon for wilderness huts.

The SVG also has some technical issues such as defining a colour. It should leave the colour undefined and then that can be done in the MSS.

@Ircama
Copy link
Contributor Author

Ircama commented Aug 23, 2016

Again, I suggest addressing a feature that is important for mountain areas, rendering it as defined in the wiki:

http://wiki.openstreetmap.org/wiki/Tag:tourism%3Dwilderness_hut
http://wiki.openstreetmap.org/wiki/Proposed_features/wilderness_mountain_buildings#Rendering

I'll revise the SVG and will remove the tab in the related marker-file.

@pnorman
Copy link
Collaborator

pnorman commented Aug 23, 2016

Again, I suggest addressing a feature that is important for mountain areas, rendering it as defined in the wiki:

I know it's defined on the wiki and the SVG is from there, but the wiki doesn't define what we render or what icons we use. Usage is one factor to consider, and I think the usage here is too low.

@matthijsmelissen
Copy link
Collaborator

I would be in favour of rendering it, but with the same icon as alpine_hut.

@Ircama
Copy link
Contributor Author

Ircama commented Aug 23, 2016

I am aware that wilderness hut has a limited usage at the moment.

Provided that considering the number of uses for a new feature to be rendered is absolutely correct, I would suggest to also evaluate the importance of a feature within its context (and also the relevance of its naming for the geography) rather than systematically checking minimum usage as a rule. In the case of wilderness hut within a mountain area, this is one of the 10/20 features which are always available in common topographic maps for its importance to users as a reference for orientation and for identifying places (other than its usage as a hut). E.g. best practices of rendering already adopted for traditional maps might be another factor to evaluate.

As already mentioned, I also see a relation between low usage of a feature and missed rendering in OSM, especially for mountain areas which have significant space of improvement for both feature definition and related rendering. In the case of wilderness hut, its current use in OSM clearly is orders of magnitude lower than reality.

As per using the same icon as alpine_hut, I would suggest differentiation because of the diverse purposes of these features, as reported in the related wiki pages (alpine huts are typically managed for most of the time, while wilderness huts are generally unmanaged and this is important information for users).

@imagico
Copy link
Collaborator

imagico commented Aug 23, 2016

As indicated before the base design of the symbol is very different from the shelter/alpine_hut design. This makes it confusing. As a minor variant of the same base design it would make sense to me, even for relatively low volume use. However there is a competing tagging for this kind of feature in form of amenity=shelter + shelter_type=basic_hut with nearly identical definition:

http://wiki.openstreetmap.org/wiki/Tag:shelter_type%3Dbasic_hut

@Ircama
Copy link
Contributor Author

Ircama commented Aug 23, 2016

IMHO the description and related proposal of icons in the Wiki for the different types of mountain buildings is pretty appropriate and I do not see a real overlapping between wilderness_hut and amenity=shelter + shelter_type=basic_hut (ref. bullets in bold in http://wiki.openstreetmap.org/wiki/Tag:tourism%3Dwilderness_hut, http://wiki.openstreetmap.org/wiki/Tag:shelter_type%3Dbasic_hut). Anyway, the latter cannot be rendered at the moment due to the need of shelter_type column.

To me, identifying five types of mountain buildings, together with their appropriate symbols, should orient mappers to improve data quality. OSM will be able to show improved information for mountain buildings vs. standard topographic maps as soon as all these symbols are rendered.

Differentiating the symbol of the generic shelter vs. the other ones might facilitate some additional accuracy in the building definition (anyway at the moment the adopted shelter symbol is similar to amenity=shelter + shelter_type=lean_to and I have not modified it in this PR).

Considering that for tourism=alpine_hut at the end we went for zoom >= 14, also tourism=wilderness_hut should have the same min zoom. I'll also rectify this.

@Ircama Ircama force-pushed the topo-extension-wilderness_hut branch from be0cc60 to b7c732d Compare August 24, 2016 06:51
@Ircama
Copy link
Contributor Author

Ircama commented Aug 24, 2016

wilderness

@Ircama
Copy link
Contributor Author

Ircama commented Aug 30, 2016

Icon revised meanwhile: now the SVG shape of wilderness_hut should look more similar to the PNG currently used for alpin_hut.

Resolves #540

wh

@Ircama Ircama changed the title Topo extension wilderness hut Add rendering for tourism=wilderness_hut Aug 30, 2016
@imagico
Copy link
Collaborator

imagico commented Aug 30, 2016

Changed symbol is a better fit.

Still think as long as amenity=shelter + shelter_type=basic_hut is not rendered in a distinct way or like tourism=wilderness_hut the latter should not be rendered different from amenity=shelter. Those two are very similar, the only difference apparently being the existence of an indoor fire place.

Otherwise the rendering will likely change the meaning of the tags and tourism=wilderness_hut will get used as a general sophisticated shelter tag instead of the specific meaning it is meant to have.

@Ircama
Copy link
Contributor Author

Ircama commented Aug 31, 2016

I agree that the differences might appear slight at first glance, nevertheless they exist and have a relevance IMHO to describe mountain buildings. In fact the wiki distinguishes them and clearly proposes separate rendering icons.

In my interpretation a wilderness_hut (as per http://wiki.openstreetmap.org/wiki/Tag:tourism%3Dwilderness_hut) is basically an unmanaged remote masonry (or wood) building used as a shelter. It could be a “malga” o “baita”.

shelter_type=basic_hut (as reported in http://wiki.openstreetmap.org/wiki/Tag:shelter_type%3Dbasic_hut) should typically be a Bivouac shelter or “bivacco” or Biwakschachtel.

You might find plenty of pictures by searching these names online and also the wiki reports some of them.

Due to the different significance of these two kinds of landmark, usually they are separately represented in standard mountain maps and generally appear as important symbols in a legenda. These adopted practices would also corroborate a low risk of misinterpretation of symbols. Databases of these mountain buildings already exist with pretty accurate documentation; I would not see a concrete possibility of tagging mismatch by mappers or possible confusion among basic_hut, wilderness_hut and alpine_hut.

I think that, by appropriately rendering these buildings as suggested by the wiki, we could provide increased value on the documentation of unpopulated mountain areas and this is at the end the aim of my proposal submitted to your evaluation.

@dieterdreist
Copy link

sent from a phone

Il giorno 31 ago 2016, alle ore 00:02, Christoph Hormann [email protected] ha scritto:

Those two are very similar, the only difference apparently being the existence of an indoor fire place.

definitely having an indoor fireplace vs. definitely not having one is a HUGE difference. I'm not sure if the not having a fireplace is guaranteed though.

@Ircama
Copy link
Contributor Author

Ircama commented Aug 31, 2016

definitely having an indoor fireplace vs. definitely not having one is a HUGE difference. I'm not sure if the not having a fireplace is guaranteed though.

Even if the wilderness_hut symbol does represent a sort of stove with a chimney, the wiki provides some additional description and rather clear example photos showing that the presence of a fireplace would not be the single difference between such buildings. In my point of view the classification made by the wiki attempts to reflect commonly adopted distinctions made for their social relevance and which the traditional maps generally also report to characterize these isolated landmarks that use to be objective references for local people as well as for tourism, sport and more generally land-use management by authorities and organizations targeted to territorial culture and countryside conservation.

@imagico
Copy link
Collaborator

imagico commented Aug 31, 2016

The point i was trying to make is that creating a three class rendering:

  • tourism=alpine_hut
  • tourism=wilderness_hut
  • amenity=shelter

will likely result in a three class tagging practice with the following meanings

  • tourism=alpine_hut - managed huts
  • tourism=wilderness_hut - any slightly sophisticated shelter
  • amenity=shelter - other shelters

which is not the suggested meaning of these tags.

A two class rendering:

  • tourism=alpine_hut
  • amenity=shelter or tourism=wilderness_hut

a four class rendering:

  • tourism=alpine_hut
  • tourism=wilderness_hut
  • amenity=shelter + shelter_type=basic_hut
  • other amenity=shelter

or a different three class rendering:

  • tourism=alpine_hut
  • tourism=wilderness_hut or amenity=shelter + shelter_type=basic_hut
  • other amenity=shelter

would all create a better incentive for correct tagging IMO. Of these currently only the two class rendering is feasible here so i think for the moment this would be the preferable solution.

@dieterdreist
Copy link

sent from a phone

Il giorno 31 ago 2016, alle ore 11:42, Christoph Hormann [email protected] ha scritto:

would all create a better incentive for correct tagging IMO. Of these currently only the two class rendering is feasible here so i think for the moment this would be the preferable solution.

a shelter is any kind of protection, including laterally open roofs etc., while any kind of hut is a kind of building with a closed room/space

@Ircama
Copy link
Contributor Author

Ircama commented Aug 31, 2016

I am personally convinced that differentiating symbols would be better incentive for correct tagging, as provides visual support on revisions.

I also think that the four class rendering is the one that better addresses the proposals in the Wiki and this could be reached in two steps: one would be the rendering of tourism=wilderness_hut (current PR) and the other (as soon as the tools will make it possible) would be the differentiation of symbols among amenity=shelter + shelter_type=basic_hut and other amenity=shelter including lean_to (as per Wiki proposals).

In unpopulated places, where the transformation of the territory is slow, isolated buildings might have a particular meaning and often deserve a certain attention in their documentation. There are many implications that would lead to consider distinguishing mountain buildings rather than managing a generic tagging; one could be for instance the historical depth of their cultural weight, which tends to reside in huts (wood, stone or masonry houses) rather than in general matter shelters (the latter generally rather small and mainly modern structures, more oriented to offering simple protection facility in some cases, for tourism or maybe related to the history and events of the alpinism in others). A hut might just be an old farm, resting or dwelling house representing an ancient social reference for local people but in some cases could also be a remodeled structure built in old centuries, testimonial of ancient work (sheep-farming, dwelling of medieval miners, resting places within ancient commercial paths crossing mountains which used to be pivotal in past centuries, etc.), or also an element of the transformation of the territory (past managed pasture vs. current unmanaged woods); there might also be a potential possibility of additional historical value, considering for instance past feudal customs subsequently transformed into shelters, or huts including memorial of conflicts or of dramatic events of past wars, etc. And OSM can play a social role in being able to represent such matters vs. other business oriented digital maps.

I anyway respect the different positions by the experienced contributors, commenters and revisors in this repository and am fully open to find a synthesis on an adoptable next step.

@Gazer75
Copy link

Gazer75 commented Sep 5, 2016

Would love seeing this rendered. It would make the map more useful to trekkers in Norway for sure.
It would display all huts that are self service or no service.

Currently there is a bit of a mess with some huts being tagged as alpine and some as wilderness.
Most likely due to the lack of rendering.

Alpine hut to me is a serviced(staffed) hut where people can take a shower and such things.

https://english.dnt.no/about-the-cabins/

@Ircama Ircama force-pushed the topo-extension-wilderness_hut branch from 7ac3b8c to 082fc06 Compare September 8, 2016 22:58
@geowOSM
Copy link

geowOSM commented Sep 11, 2016

I personally would be in favour of rendering wilderness_hut, but with a different icon than alpine_hut.
There is a fundamental difference - wilderness huts are self serviced and don't provide staff to service food, beverages etc . They also might be locked and require picking up a key prior to the ascent.

@Ircama Ircama force-pushed the topo-extension-wilderness_hut branch from 082fc06 to edb5fb6 Compare September 17, 2016 12:12
@Ircama
Copy link
Contributor Author

Ircama commented Sep 17, 2016

Rebased

@Ircama Ircama force-pushed the topo-extension-wilderness_hut branch from edb5fb6 to 820de3c Compare September 25, 2016 08:01
@Ircama Ircama force-pushed the topo-extension-wilderness_hut branch from 820de3c to 6a1e275 Compare October 14, 2016 23:04
@Ircama
Copy link
Contributor Author

Ircama commented Oct 21, 2016

wilderness_hut

@Ircama Ircama force-pushed the topo-extension-wilderness_hut branch from 6a1e275 to ef3c51d Compare October 30, 2016 19:11
@nebulon42 nebulon42 self-assigned this Nov 19, 2016
@nebulon42
Copy link
Contributor

I planned to provide a sequence of shelter icons for some time now. But didn't find the right solution, maybe I was expecting too much. So I'm definitely in favour of rendering these. The small number of uses is not really a problem because of their importance in remote areas. I'm also ok with the zoom level.

@imagico re your concerns: A basic hut or Biwakschachtel is usually very different from a more sophisticated shelter as you named it. So I think the distinction the Wiki makes is correct and non-overlapping. I have found mis-taggings around alpine_huts and wilderness_huts and confusion with chalets, but this is likely a Wiki problem. Generally, the tagging scheme is not ideal but that's what exists. Not being currently able to differentiate shelter_types is a drawback, but should not hinder the inclusion of this.

The icon has a few issues which I plan to address. Examples: no compound shape, 580px as size, chimney could be better visible, not pixel aligned everywhere. At the same time I can also work on the SVG replacement of alpine_hut.

So currently not mergeable due to icon issues.
@Ircama I will provide you an updated icon you can include if you want.

@imagico
Copy link
Collaborator

imagico commented Nov 19, 2016

All right - my concern that this kind of rendering could lead to use of tourism=wilderness_hut bleeding into the domain of amenity=shelter still exists but i won't insist i can predict the future better than everyone else can. 😄

@Ircama
Copy link
Contributor Author

Ircama commented Nov 20, 2016

@nebulon42: thanks very much for taking care. I will rely on your feedback or you can also take over, just as you prefer.

@nebulon42
Copy link
Contributor

I have now created icons for alpine_hut, wilderness_hut, basic_shelter and shelter. This should be discussed together in my opinion.
Find them here: https://github.com/gmgeo/osmic/tree/master/outdoor
wilderness_hut is immediately usable, I'm not so sure about alpine_hut, but it will be the basic shape with something in it. Still have to test it on the map. Maybe we also should think of slightly altering the shape of the current shelter icon so that is different from the other tree.

@Ircama if you take this icon width and height in CartoCSS should become unneccessary.

@Ircama
Copy link
Contributor Author

Ircama commented Nov 21, 2016

Icons are beautiful. Just some concern with alpine_hut which is quite different from the one currently in place. I will update wilderness_hut and test it.

@Ircama
Copy link
Contributor Author

Ircama commented Nov 21, 2016

Just some preliminary sample based on @nebulon42's work before pushing the code.

Shelter:
hut1

wilderness_hut (also alpine_hut with original PNG icon):
hut2

wilderness_hut (alpine_hut has the new SVG icon): it will possibly not be part of this PR, but I am showing here a sample to allow comparing:
hut3

This is the code I used in the last sample to test both new icons of alpine_hut and wilderness_hut:

  [feature = 'tourism_alpine_hut'][zoom >= 13] {
    marker-file: url('symbols/alpine-hut-14.svg');
    marker-fill: @transportation-icon;
    marker-placement: interior;
    marker-clip: false;
  }

  [feature = 'tourism_wilderness_hut'][zoom >= 13],
  [feature = 'amenity_shelter'][zoom >= 16] {
    marker-file: url('symbols/shelter-14.svg');
    [feature = 'tourism_wilderness_hut'] {
      marker-file: url('symbols/wilderness-hut-14.svg');
    }
    marker-fill: @transportation-icon;
    marker-placement: interior;
    marker-clip: false;
  }

I would suggest the original icon for wilderness huts (subjective opinion maybe).

On this PR, I consider appropriate the new wilderness_hut and shelter icons and suggest both are part of the new commit.

Please let me know, thanks.

@imagico
Copy link
Collaborator

imagico commented Nov 21, 2016

I am not sure if the different shelter icon is a good idea - but this should be a separate PR anyway, keep this limited to adding wilderness_hut please.

@Ircama
Copy link
Contributor Author

Ircama commented Nov 21, 2016

keep this limited to adding wilderness_hut please.

Ok, no problem.

@nebulon42
Copy link
Contributor

keep this limited to adding wilderness_hut please.

Ah, that's what I had in mind too. Sorry for being not clear on this.

@Ircama Ircama force-pushed the topo-extension-wilderness_hut branch from ef3c51d to 383f966 Compare November 22, 2016 08:09
@Ircama
Copy link
Contributor Author

Ircama commented Nov 22, 2016

This is a test commit+rebase, where I updated wilderness_hut with @nebulon42’s icon keeping alpine_hut and shelter-14.svg unchanged, as requested.

It also generates project.mml with Windows and with #2459 (just project.mml, without updating the script program). I see that Travis CI does not like it (possibly because the tags are not in the expected order).

I will do again a commit+rebase with the original scripts\yaml2mml.py and complete with a sample image for the standard shelter.

@Ircama Ircama force-pushed the topo-extension-wilderness_hut branch from e2faadf to a312fb7 Compare November 26, 2016 15:04
@Ircama
Copy link
Contributor Author

Ircama commented Nov 26, 2016

Just would like to receive confirmation that the tag id="wilderness-hut" in wilderness_hut.svg is appropriate (dash instead of underline).

@nebulon42
Copy link
Contributor

@Ircama I think that the id is just a minor detail. Is this now ready from your side?

Code completed

amenity-points.mss and symbols/wilderness_hut.svg are ready for merge.

Latest changes:
- I have now changed the file naming of wilderness_hut.svg (with icon produced by @nebulon42) following @nebulon42's convention in gravitystorm#2451.
- Rebased to master

______________________________________________________________________

To summarize, the following different kind of huts have specific symbols now:

- amenity=shelter (only shown at zoom >=16)
- tourism=alpine_hut  (not modified within this drop)
- tourism=wilderness_hut (zoom>=13)

Symbols:
- wilderness_hut: symbols/wilderness_hut.svg (new)
- alpine_hut: symbols/alpinehut.p.16.png (unmodified)
- generic shelter: symbols/shelter.svg (unmodified)
@Ircama Ircama force-pushed the topo-extension-wilderness_hut branch from a312fb7 to 063a9eb Compare November 29, 2016 01:05
@Ircama
Copy link
Contributor Author

Ircama commented Nov 29, 2016

@nebulon42: code ready for revision/merge

@nebulon42
Copy link
Contributor

Thanks! I manually merged this, because I had to change width/height of the SVG to the respective pixel values.

Just a note: While it is good to have meaningful commit messages they don't need to be too extensive. No need to include the complete history of the PR into the commit message.

@nebulon42 nebulon42 closed this Dec 1, 2016
@Gazer75
Copy link

Gazer75 commented Dec 1, 2016

Noticed a conflict here in Norway, because there are two types of wilderness huts. Some have provisions and some don't. To add this info a shop=provisions is added. This might override the new hut rendering by thinking its a generic shop.

@nebulon42
Copy link
Contributor

@Gazer75 Interesting observation, very helpful. Please open a separate ticket for it.

@Ircama
Copy link
Contributor Author

Ircama commented Dec 2, 2016

To add this info a shop=provisions is added

I'll investigate. Could you please provide some example meanwhile? Is it documented in the wiki?

@Gazer75
Copy link

Gazer75 commented Dec 2, 2016

Example node: https://www.openstreetmap.org/node/666788642

Wiki mention tagging for huts in Norway here(scroll up half a page to "Turisthytte"):
https://wiki.openstreetmap.org/wiki/Import/Catalogue/N50_import_(Norway)#Changeset_tags

The Norwegian Trekking Association(DNT) maintains around 500 cabins/huts around the country
https://english.dnt.no/

Map of the DNT cabins(red icon) and other lodging(blue) can be seen here:
https://www.ut.no/kart/
This map works mostly ok with Chrome and its page translation.
Most, if not all, shown on this map are also in OSM as DNT members have added them over the years.

@Ircama
Copy link
Contributor Author

Ircama commented Dec 2, 2016

@Gazer75 I see now @nebulon42's recommendation to open a new ticket; I also would suggest this. After a quick review, I see that your request is related to a massive import from Norway about tourist huts and I do not see it clearly documented in the main Wiki (apart from a mention in the Norwegian one without English note). But it would be appropriate that such investigation is performed in the new ticket.

There are at the moment 153 PoIs with node["tourism"="wilderness_hut"]["shop"="provisions"] (all in South Norway) and no way/polygon. 151 of them have node[affiliation='Den Norske Turistforening'] so are expected to be part of the import.

@pnorman pnorman mentioned this pull request Dec 2, 2016
@Ircama Ircama deleted the topo-extension-wilderness_hut branch December 15, 2016 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants