Add a null check to getMfaChallengeResponse
#50570
Open
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
reviewed
Dec 24, 2024
| @@ -69,7 +69,7 @@ export function parseMfaChallengeJson( | |||
| !challenge.webauthn_challenge && | |||
| !challenge.totp_challenge | |||
| ) { | |||
| return null; | |||
| return; | |||
There was a problem hiding this comment.
Should the return type of this function be MfaAuthenciateChallenge | undefined?
We don't have strict null checks enabled right now, but if we did this would not compile as-is.
| @@ -282,6 +282,8 @@ const auth = { | |||
| mfaType?: DeviceType, | |||
| totpCode?: string | |||
| ): Promise<MfaChallengeResponse> { | |||
There was a problem hiding this comment.
Perhaps?
Suggested change
| ): Promise<MfaChallengeResponse> { | |
| ): Promise<MfaChallengeResponse|undefined> { |
| @@ -282,6 +282,8 @@ const auth = { | |||
| mfaType?: DeviceType, | |||
| totpCode?: string | |||
| ): Promise<MfaChallengeResponse> { | |||
| if (!challenge) return; | |||
There was a problem hiding this comment.
We return undefined here, but null on line 315. Can we be more consistent and explicit about the behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix a bug in the WebUI for some MFA actions for users with no MFA devices, or where MFA is not required for the user.
Fix a bug caused by #49679 which was meant to check for null/undefined.
Closes #50556