Add RequestIdentityMode to PDP requests #50482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
added
the
no-changelog
rosstimothy
approved these changes
Dec 20, 2024
greedy52
approved these changes
Dec 20, 2024
public-teleport-github-review-bot
bot
removed request for
timothyb89 and
fspmarshall
|
Thanks for the reviews. @fspmarshall has an alternative design in mind, so I'll hold this until his has a chance to be reviewed. |
Friendly ping @fspmarshall. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RequestIdentityMode to PDP requests, allowing callers to more easily query about 3rd parties or themselves.
Without this feature callers would have to always form a complete request identity, which is
(error-prone) busywork when querying about self and needless complexity when querying about 3rd parties (whose identities those tools shouldn't need to or even be able to form).
Querying about 3rd parties is subject to authz controls, naturally.
#49837