Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding web-flow to CLA allowlist #50469

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

Adding web-flow to CLA allowlist #50469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/cla-assistant.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,8 @@ jobs:
path-to-document: 'https://github.com/gravitational/teleport/blob/master/CLA.md'
# branch should not be protected
branch: 'main'
allowlist: 'dependabot[bot],teleport-post-release-automation[bot]'
# dependabot: Dependency management tool that keeps us up-to-date on latest releases
# teleport-post-release-automation: Creates PRs for updating docs after a release is made
# web-flow: GitHub owned user that owns commits that are done through Web APIs
allowlist: 'dependabot[bot],teleport-post-release-automation[bot],web-flow'
Copy link
Contributor

@fheinecke fheinecke Dec 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could an external contributor use GH's web APIs to commit code (in the same manner as the post-release automation) and bypass this check?

What's the actual (legal) impact of an external contributor doing this? If there isn't a quick/easy answer, is it even worth the time to investigate, or should we just merge this as is?

lock-pullrequest-aftermerge: false
Loading