docs: update tls cert private instrs #50418
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenGravy
added
no-changelog
github-actions
bot
requested review from
mmcallister,
ptgott,
r0mant,
xinding33 and
zmb3
|
🤖 Vercel preview here: https://docs-iu7ojqpss-goteleport.vercel.app/docs |
webvictim
approved these changes
Dec 19, 2024
|
🤖 Vercel preview here: https://docs-7u80jeayi-goteleport.vercel.app/docs |
ptgott
approved these changes
Dec 19, 2024
zmb3
reviewed
Dec 19, 2024
| @@ -30,7 +30,8 @@ deployments, use your own private key and certificate. | |||
| On your Teleport host, place a valid private key and a certificate chain in `/var/lib/teleport/privkey.pem` | |||
| and `/var/lib/teleport/fullchain.pem` respectively. | |||
|
|
|||
| The leaf certificate must have a subject that corresponds to the domain of your Teleport host, e.g., `*.teleport.example.com`. | |||
| The leaf certificate must have a subject that corresponds to the domain of your Teleport host, e.g., `teleport.example.com` | |||
| with mapped sub-domains as alternate names, e.g., `*.teleport.example.com`. | |||
There was a problem hiding this comment.
Do we expect people to know what mapped sub-domains are? I'm not sure I would know what this meant if I wasn't already familiar with Teleport.
There was a problem hiding this comment.
Subdomains are mentioned in step 1 for web applications. We can reword it another way if that will make it more clear.
There was a problem hiding this comment.
Example usage from here. https://goteleport.com/docs/admin-guides/deploy-a-cluster/linux-demo/#step-14-configure-dns.
I did a wording update.
|
🤖 Vercel preview here: https://docs-gnywjq6ct-goteleport.vercel.app/docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions just mentioned the wildcard cert for private certs.