Adding the Azure sync module functions along with new cloud client functionality #50366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvbrock
changed the base branch from
master
to
mvbrock/azure-integration-disco-proto
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure
branch
from
a817501 to
e88e148
Compare
Base automatically changed from
mvbrock/azure-integration-disco-proto
to
master
December 18, 2024 20:24
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure
branch
from
e88e148 to
308bc2c
Compare
mvbrock
added
the
no-changelog
tigrato
reviewed
Dec 19, 2024
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure
branch
from
02bcb5e to
0a4c1f4
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure
branch
from
0a4c1f4 to
672ae8d
Compare
|
🤖 Vercel preview here: https://docs-hx7av502y-goteleport.vercel.app/docs |
| } | ||
|
|
||
| // ListRoleDefinitions returns role definitions for a given scope | ||
| func (c *RoleDefinitionsClient) ListRoleDefinitions(ctx context.Context, scope string) ([]*armauthorization.RoleDefinition, error) { |
There was a problem hiding this comment.
Is it worth to add a max items? Even if something configurable and default to pretty high value.
Given that we load everything into memory, I wonder if could ever reach a memory limit.
There was a problem hiding this comment.
Probably yes at some point in the future--some kind of corresponding paging functionality where results are buffered to the access graph. If we do that, we'd want to do it for all resources in AWS and Azure. Thoughts @tigrato?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a result of splitting #48843 into smaller PRs, and provides the Azure fetching functions and new cloud client functionality specifically for role assignments and definitions. This PR also incorporates the existing lib/msgraph client and removes the extraneous client code from the original PR.