Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Fix display of Wizards' StepList with hidden items #49734

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

kiosion
Copy link
Contributor

@kiosion kiosion commented Dec 3, 2024

Index step numbers to display separately, so hidden steps don't increase later steps' index in rendered list.

@kiosion kiosion added the no-changelog Indicates that a PR does not require a changelog entry label Dec 3, 2024
@github-actions github-actions bot requested a review from flyinghermit December 3, 2024 22:51
@github-actions github-actions bot added the ui label Dec 3, 2024
@github-actions github-actions bot requested a review from ravicious December 3, 2024 22:51
@kiosion kiosion force-pushed the maxim/fix-steplist branch from 026ec4a to ae35467 Compare December 3, 2024 22:52
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-49734.d3pp5qlev8mo18.amplifyapp.com

@kiosion kiosion requested a review from ravicious December 13, 2024 18:24
- Use `displayIndex` prop to seperately track step numbers to display
@kiosion kiosion added this pull request to the merge queue Dec 20, 2024
Merged via the queue into master with commit 92c1cec Dec 20, 2024
42 checks passed
@kiosion kiosion deleted the maxim/fix-steplist branch December 20, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants