Pass correct results to TraceBatchFinishFunc #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The slice of *Result objects passed to TraceBatchFinishFunc was always empty. By moving the `defer finish(items)` down below where items is assigned the results of the batch function, tracers are passed the actual results. Fixes graph-gophers#63.
mjq
force-pushed
the
fix_trace_batch_results
branch
from
baacb48 to
d659c93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I ran into #63 while using this library, so I took a pass at fixing it. Happy to make updates if you have any suggestions or concerns re: style or substance 😄 Thanks!