refactor: explicitly specify username property in search method #158
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the Change Does
🔧 Additional Parameter: We are now explicitly specifying the propertyName as 'username' instead of leaving it null.
In the like method, if propertyName is null, it is set as the result of toPropertyName(paramName). By explicitly providing 'username', we ensure that the propertyName used in the search is exactly 'username'.
✨ Clarity Improvement: This change is useful if paramName and propertyName can be different in some context, but in this specific case, we are only making explicit what was already being done implicitly.
Impact of the Change
📝 Clarity: It makes it more explicit that the username field is both the parameter name and the property name to search.
⚙️ Functionality: This should not change functionality in this specific case because toPropertyName('username') was likely already returning 'username'.