Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom wait delay #4446

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Allow custom wait delay #4446

merged 3 commits into from
Jun 3, 2024

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Jun 3, 2024

What this PR does

Same as #4422 but returns wait delays as strings so it's backward-compatible with the mobile app API calls.

Which issue(s) this PR closes

Related to #2464

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@vstpme vstpme temporarily deployed to github-pages June 3, 2024 12:09 — with GitHub Actions Inactive
@vstpme vstpme temporarily deployed to github-pages June 3, 2024 12:40 — with GitHub Actions Inactive
@vstpme vstpme added pr:no public docs Added to a PR that does not require public documentation updates release:enhancement PR will be added to "Exciting New Features 🎉" section of release notes labels Jun 3, 2024
@vstpme vstpme marked this pull request as ready for review June 3, 2024 13:01
@vstpme vstpme requested review from a team June 3, 2024 13:01
@vstpme vstpme added this pull request to the merge queue Jun 3, 2024
Merged via the queue into dev with commit fafc336 Jun 3, 2024
25 of 27 checks passed
@vstpme vstpme deleted the vadimkerr/custom-wait-delay branch June 3, 2024 13:14
brojd pushed a commit that referenced this pull request Sep 18, 2024
# What this PR does

Same as #4422 but returns wait
delays as strings so it's backward-compatible with the mobile app API
calls.

## Which issue(s) this PR closes

Related to #2464

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:enhancement PR will be added to "Exciting New Features 🎉" section of release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants