Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: put k6 crds in the appropriate folder specified by Helm #506

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mariuskimmina
Copy link

This PR aims to put CRDs folder in the appropriate folder specified by Helm which is charts/crds, so that we can skip installing CRDs whenever we want.
Please refer to: https://helm.sh/docs/topics/charts/#custom-resource-definitions-crds

I recon that an options installCRDs has been added here #342 but it would imo be better to follow the recommended structure and let helms skip-crds option handle this.

I'd like to see one of these two options

  • have both options of skip-crds and installCRDs
  • only keep the standardized skip-crds and clean up installCRDs

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2024

CLA assistant check
All committers have signed the CLA.

@mariuskimmina
Copy link
Author

mariuskimmina commented Dec 12, 2024

Ah, I see, this would loose the option to template out CRDs - so keeping both installCRDs and using skip-crds may not be an option.

Relevant discussion on the topic: cert-manager/cert-manager#6179

@mariuskimmina
Copy link
Author

Perhaps #505 would actually be the better solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants