Handle deprecation of gcr.io/kubebuilder #503
Merged
+10
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
monteiro-renato
force-pushed
the
patch-1
branch
from
592ea33 to
06c6fb0
Compare
yorugac
requested changes
Dec 15, 2024
There was a problem hiding this comment.
Hi @monteiro-renato, thanks for working on this!
I believe this is actually part of #235 and that issue should be solved with ~ "option 1".
I'm happy to merge this as is now, except for one small change request. But in case you'd like to work on ~ option 1, please feel free to, assuming you have the time for this work this coming week 🙂 I'll also have the time to review and test it as needs be on this week.
PS signing CLA is mandatory! I can't merge anything without that.
bundle.yaml
Outdated
| @@ -12252,7 +12252,7 @@ spec: | |||
| - --upstream=http://127.0.0.1:8080/ | |||
| - --logtostderr=true | |||
| - --v=10 | |||
| image: gcr.io/kubebuilder/kube-rbac-proxy:v0.15.0 | |||
There was a problem hiding this comment.
This change should be removed: bundle.yaml is generated on each release and is not kept up-to-date to main otherwise.
monteiro-renato
force-pushed
the
patch-1
branch
from
06c6fb0 to
4bc73da
Compare
yorugac
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
It will soon not be possible to pull images from gcr.io/kubebuilder. See this discussion for more details: kubernetes-sigs/kubebuilder#3907 (Also in the operator-sdk README).
This PR opts for option 3 but I guess ideally we should go with option 1. I'm not sure if you were aware of this so I'm opening this PR for awareness. Feel free to provide me some guidance if you feel like we should tackle this issue in some other way. I believe I will have the time to work on this.